2023-01-24 14:41:47

by Anand Moon

Subject: [PATCH linux-next v4 4/4] dt-bindings: usb: Fix device tree binding for VL817 hub controller

Cleanup by removing unneeded quotes from refs and
add maxItems to reset-gpios and fix the required list.

Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Signed-off-by: Anand Moon <[email protected]>
---
.../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++--------
1 file changed, 10 insertions(+), 8 deletions(-)

diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
index 5f9771e22058..23a13e1d5c7a 100644
--- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
+++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
@@ -14,29 +14,32 @@ allOf:

properties:
compatible:
- items:
- - enum:
- - usb2109,2817
- - usb2109,817
+ enum:
+ - usb2109,2817
+ - usb2109,817

reg: true

reset-gpios:
- description: GPIO controlling the RESET# pin.
+ maxItems: 1
+ description:
+ GPIO controlling the RESET# pin.

vdd-supply:
description:
phandle to the regulator that provides power to the hub.

peer-hub:
- $ref: '/schemas/types.yaml#/definitions/phandle'
+ $ref: /schemas/types.yaml#/definitions/phandle
description:
phandle to the peer hub on the controller.

required:
- - peer-hub
- compatible
- reg
+ - reset-gpios
+ - vdd-supply
+ - peer-hub

additionalProperties: false

@@ -45,7 +48,6 @@ examples:
#include <dt-bindings/gpio/gpio.h>

usb {
- dr_mode = "host";
#address-cells = <1>;
#size-cells = <0>;

--
2.38.1

2023-01-24 15:18:05

by Krzysztof Kozlowski

Subject: Re: [PATCH linux-next v4 4/4] dt-bindings: usb: Fix device tree binding for VL817 hub controller

On 24/01/2023 15:40, Anand Moon wrote:
> Cleanup by removing unneeded quotes from refs and
> add maxItems to reset-gpios and fix the required list.
>
> Fixes: 31360c28dfdd ("dt-bindings: usb: Add binding for Via lab VL817 hub controller")
> Reviewed-by: Krzysztof Kozlowski <[email protected]>

I think it's the first time I see this patch. Where did I review it?

Use subject prefixes matching the subsystem (which you can get for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching).

Subject: drop second/last, redundant "device tree binding for". The
"dt-bindings" prefix is already stating that these are bindings.


> Signed-off-by: Anand Moon <[email protected]>
> ---
> .../devicetree/bindings/usb/vialab,vl817.yaml | 18 ++++++++++--------
> 1 file changed, 10 insertions(+), 8 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
> index 5f9771e22058..23a13e1d5c7a 100644
> --- a/Documentation/devicetree/bindings/usb/vialab,vl817.yaml
> +++ b/Documentation/devicetree/bindings/usb/vialab,vl817.yaml


Best regards,
Krzysztof