2023-01-20 07:39:56

by Krzysztof Kozlowski

Subject: [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible

Document existing fsl,imx6ul-gpc compatible used with fsl,imx6q-gpc
fallback:

imx6sl-evk.dtb: gpc@20dc000: compatible: ['fsl,imx6sl-gpc', 'fsl,imx6q-gpc'] is too long

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../devicetree/bindings/power/fsl,imx-gpc.yaml | 15 ++++++++++-----
1 file changed, 10 insertions(+), 5 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index 777e1d852ddd..85658da3672f 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -23,11 +23,16 @@ description: |

properties:
compatible:
- enum:
- - fsl,imx6q-gpc
- - fsl,imx6qp-gpc
- - fsl,imx6sl-gpc
- - fsl,imx6sx-gpc
+ oneOf:
+ - enum:
+ - fsl,imx6q-gpc
+ - fsl,imx6qp-gpc
+ - fsl,imx6sl-gpc
+ - fsl,imx6sx-gpc
+ - items:
+ - enum:
+ - fsl,imx6ul-gpc
+ - const: fsl,imx6q-gpc

reg:
maxItems: 1
--
2.34.1

2023-01-20 08:02:14

by Krzysztof Kozlowski

Subject: [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller

The fsl,imx6q-gpc is used as interrupt controller (routing back to GIC):

imx6sl-evk.dtb: gpc@20dc000: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+'

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index a5ea45b8c04e..c21a66422d4f 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -40,6 +40,10 @@ properties:
interrupts:
maxItems: 1

+ interrupt-controller: true
+ '#interrupt-cells':
+ const: 3
+
clocks:
maxItems: 1

--
2.34.1

2023-01-20 08:04:29

by Krzysztof Kozlowski

Subject: [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles

fsl,imx6qp-gpc, fsl,imx6sl-gpc and fsl,imx6sx-gpc use generic fallback
fsl,imx6q-gpc in the DTS, even though these are different devices. The
common part (thus the fallback) is a interrupt controller routing back
to GIC.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
index 85658da3672f..a5ea45b8c04e 100644
--- a/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
+++ b/Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml
@@ -26,11 +26,11 @@ properties:
oneOf:
- enum:
- fsl,imx6q-gpc
- - fsl,imx6qp-gpc
- - fsl,imx6sl-gpc
- - fsl,imx6sx-gpc
- items:
- enum:
+ - fsl,imx6qp-gpc
+ - fsl,imx6sl-gpc
+ - fsl,imx6sx-gpc
- fsl,imx6ul-gpc
- const: fsl,imx6q-gpc

--
2.34.1

2023-01-23 21:56:35

by Rob Herring (Arm)

Subject: Re: [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible

On Fri, 20 Jan 2023 08:17:15 +0100, Krzysztof Kozlowski wrote:
> Document existing fsl,imx6ul-gpc compatible used with fsl,imx6q-gpc
> fallback:
>
> imx6sl-evk.dtb: gpc@20dc000: compatible: ['fsl,imx6sl-gpc', 'fsl,imx6q-gpc'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> .../devicetree/bindings/power/fsl,imx-gpc.yaml | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2023-01-23 21:58:15

by Rob Herring (Arm)

Subject: Re: [PATCH 2/3] dt-bindings: power: fsl,imx-gpc: correct compatibles

On Fri, 20 Jan 2023 08:17:16 +0100, Krzysztof Kozlowski wrote:
> fsl,imx6qp-gpc, fsl,imx6sl-gpc and fsl,imx6sx-gpc use generic fallback
> fsl,imx6q-gpc in the DTS, even though these are different devices. The
> common part (thus the fallback) is a interrupt controller routing back
> to GIC.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>

Acked-by: Rob Herring <[email protected]>

2023-01-23 21:58:24

by Rob Herring (Arm)

Subject: Re: [PATCH 3/3] dt-bindings: power: fsl,imx-gpc: document interrupt-controller

On Fri, 20 Jan 2023 08:17:17 +0100, Krzysztof Kozlowski wrote:
> The fsl,imx6q-gpc is used as interrupt controller (routing back to GIC):
>
> imx6sl-evk.dtb: gpc@20dc000: '#interrupt-cells', 'interrupt-controller' do not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/power/fsl,imx-gpc.yaml | 4 ++++
> 1 file changed, 4 insertions(+)
>

Acked-by: Rob Herring <[email protected]>

2023-01-26 08:42:52

by Shawn Guo

Subject: Re: [PATCH 1/3] dt-bindings: power: fsl,imx-gpc: document fsl,imx6ul-gpc compatible

On Fri, Jan 20, 2023 at 08:17:15AM +0100, Krzysztof Kozlowski wrote:
> Document existing fsl,imx6ul-gpc compatible used with fsl,imx6q-gpc
> fallback:
>
> imx6sl-evk.dtb: gpc@20dc000: compatible: ['fsl,imx6sl-gpc', 'fsl,imx6q-gpc'] is too long
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied all, thanks!