2023-01-24 11:59:45

by Leon Romanovsky

[permalink] [raw]
Subject: [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack

Changelog
v1:
* Fixed rebase errors in mlx5 and cxgb4 drivers
* Fixed previously existed typo in nfp driver
* Added Simon's ROB
* Removed my double SOB tags
v0: https://lore.kernel.org/all/[email protected]

---------------------------------------------------------------------------

Hi,

This series continues effort started by Sabrina to return XFRM configuration
errors through extack. It allows for user space software stack easily present
driver failure reasons to users.

As a note, Intel drivers have a path where extack is equal to NULL, and error
prints won't be available in current patchset. If it is needed, it can be
changed by adding special to Intel macro to print to dmesg in case of
extack == NULL.

Thanks

Leon Romanovsky (10):
xfrm: extend add policy callback to set failure reason
net/mlx5e: Fill IPsec policy validation failure reason
xfrm: extend add state callback to set failure reason
net/mlx5e: Fill IPsec state validation failure reason
netdevsim: Fill IPsec state validation failure reason
nfp: fill IPsec state validation failure reason
ixgbevf: fill IPsec state validation failure reason
ixgbe: fill IPsec state validation failure reason
bonding: fill IPsec state validation failure reason
cxgb4: fill IPsec state validation failure reason

Documentation/networking/xfrm_device.rst | 4 +-
drivers/net/bonding/bond_main.c | 10 +-
.../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 8 +-
.../inline_crypto/ch_ipsec/chcr_ipsec.c | 34 +++---
.../net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 27 ++---
drivers/net/ethernet/intel/ixgbevf/ipsec.c | 21 ++--
.../mellanox/mlx5/core/en_accel/ipsec.c | 103 ++++++++----------
.../net/ethernet/netronome/nfp/crypto/ipsec.c | 41 +++----
drivers/net/netdevsim/ipsec.c | 14 +--
include/linux/netdevice.h | 4 +-
net/xfrm/xfrm_device.c | 9 +-
net/xfrm/xfrm_state.c | 2 +-
12 files changed, 137 insertions(+), 140 deletions(-)

--
2.39.1



2023-01-25 19:01:44

by Jakub Kicinski

[permalink] [raw]
Subject: Re: [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack

On Tue, 24 Jan 2023 13:54:56 +0200 Leon Romanovsky wrote:
> This series continues effort started by Sabrina to return XFRM configuration
> errors through extack. It allows for user space software stack easily present
> driver failure reasons to users.

Steffen, would you like to take these into your tree or should we apply
directly? Looks like mostly driver changes.

2023-01-26 09:43:14

by Steffen Klassert

[permalink] [raw]
Subject: Re: [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack

On Wed, Jan 25, 2023 at 11:01:33AM -0800, Jakub Kicinski wrote:
> On Tue, 24 Jan 2023 13:54:56 +0200 Leon Romanovsky wrote:
> > This series continues effort started by Sabrina to return XFRM configuration
> > errors through extack. It allows for user space software stack easily present
> > driver failure reasons to users.
>
> Steffen, would you like to take these into your tree or should we apply
> directly? Looks like mostly driver changes.

You can just take it directly as it is mostly driver changes.
The ipsec-next tree is currently empty so there will be no
conflicts.

Thanks!

2023-01-27 00:50:27

by patchwork-bot+netdevbpf

[permalink] [raw]
Subject: Re: [PATCH net-next v1 00/10] Convert drivers to return XFRM configuration errors through extack

Hello:

This series was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Tue, 24 Jan 2023 13:54:56 +0200 you wrote:
> Changelog
> v1:
> * Fixed rebase errors in mlx5 and cxgb4 drivers
> * Fixed previously existed typo in nfp driver
> * Added Simon's ROB
> * Removed my double SOB tags
> v0: https://lore.kernel.org/all/[email protected]
>
> [...]

Here is the summary with links:
- [net-next,v1,01/10] xfrm: extend add policy callback to set failure reason
https://git.kernel.org/netdev/net-next/c/3089386db090
- [net-next,v1,02/10] net/mlx5e: Fill IPsec policy validation failure reason
https://git.kernel.org/netdev/net-next/c/1bb70c5ab6ec
- [net-next,v1,03/10] xfrm: extend add state callback to set failure reason
https://git.kernel.org/netdev/net-next/c/7681a4f58fb9
- [net-next,v1,04/10] net/mlx5e: Fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/902812b81604
- [net-next,v1,05/10] netdevsim: Fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/6c4869795568
- [net-next,v1,06/10] nfp: fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/05ddf5f8cb6c
- [net-next,v1,07/10] ixgbevf: fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/c068ec5c964d
- [net-next,v1,08/10] ixgbe: fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/505c500cfcb4
- [net-next,v1,09/10] bonding: fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/3fe57986271a
- [net-next,v1,10/10] cxgb4: fill IPsec state validation failure reason
https://git.kernel.org/netdev/net-next/c/8c284ea429d2

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html