2023-01-26 18:25:42

by Fedor Pchelkin

Subject: [PATCH] wifi: ath6kl: reduce WARN to dev_dbg() in callback

The warn is triggered on a known race condition that is correctly handled.
Using WARN() hinders automated testing. Reducing severity.

Fixes: de2070fc4aa7 ("ath6kl: Fix kernel panic on continuous driver load/unload")
Reported-and-tested-by: [email protected]
Signed-off-by: Oliver Neukum <[email protected]>
Signed-off-by: Fedor Pchelkin <[email protected]>
Signed-off-by: Alexey Khoroshilov <[email protected]>
---
drivers/net/wireless/ath/ath6kl/htc_pipe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/net/wireless/ath/ath6kl/htc_pipe.c b/drivers/net/wireless/ath/ath6kl/htc_pipe.c
index c68848819a52..9b88d96bfe96 100644
--- a/drivers/net/wireless/ath/ath6kl/htc_pipe.c
+++ b/drivers/net/wireless/ath/ath6kl/htc_pipe.c
@@ -960,8 +960,8 @@ static int ath6kl_htc_pipe_rx_complete(struct ath6kl *ar, struct sk_buff *skb,
* Thus the possibility of ar->htc_target being NULL
* via ath6kl_recv_complete -> ath6kl_usb_io_comp_work.
*/
- if (WARN_ON_ONCE(!target)) {
- ath6kl_err("Target not yet initialized\n");
+ if (!target) {
+ ath6kl_dbg(ATH6KL_DBG_HTC, "Target not yet initialized\n");
status = -EINVAL;
goto free_skb;
}
--
2.34.1

2023-02-27 12:20:07

by Kalle Valo

Subject: Re: [PATCH] wifi: ath6kl: reduce WARN to dev_dbg() in callback

Fedor Pchelkin <[email protected]> wrote:

> The warn is triggered on a known race condition, documented in the code above
> the test, that is correctly handled. Using WARN() hinders automated testing.
> Reducing severity.
>
> Fixes: de2070fc4aa7 ("ath6kl: Fix kernel panic on continuous driver load/unload")
> Reported-and-tested-by: [email protected]
> Signed-off-by: Oliver Neukum <[email protected]>
> Signed-off-by: Fedor Pchelkin <[email protected]>
> Signed-off-by: Alexey Khoroshilov <[email protected]>
> Signed-off-by: Kalle Valo <[email protected]>

Patch applied to ath-next branch of ath.git, thanks.

75c4a8154cb6 wifi: ath6kl: reduce WARN to dev_dbg() in callback

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches