2023-01-27 11:01:48

by Jean Delvare

[permalink] [raw]
Subject: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
is possible to test-build any driver which depends on OF on any
architecture by explicitly selecting OF. Therefore depending on
COMPILE_TEST as an alternative is no longer needed.

Signed-off-by: Jean Delvare <[email protected]>
Cc: Paul Kocialkowski <[email protected]>
Cc: David Airlie <[email protected]>
Cc: Daniel Vetter <[email protected]>
---
drivers/gpu/drm/logicvc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

--- linux-6.1.orig/drivers/gpu/drm/logicvc/Kconfig
+++ linux-6.1/drivers/gpu/drm/logicvc/Kconfig
@@ -1,7 +1,7 @@
config DRM_LOGICVC
tristate "LogiCVC DRM"
depends on DRM
- depends on OF || COMPILE_TEST
+ depends on OF
select DRM_KMS_HELPER
select DRM_KMS_DMA_HELPER
select DRM_GEM_DMA_HELPER


--
Jean Delvare
SUSE L3 Support


2023-01-30 09:15:54

by Paul Kocialkowski

[permalink] [raw]
Subject: Re: [PATCH RESEND] drm/logicvc: Drop obsolete dependency on COMPILE_TEST

Hi Jean,

On Fri 27 Jan 23, 12:01, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
>
> Signed-off-by: Jean Delvare <[email protected]>
> Cc: Paul Kocialkowski <[email protected]>
> Cc: David Airlie <[email protected]>
> Cc: Daniel Vetter <[email protected]>

Sounds good to me!

Reviewed-by: Paul Kocialkowski <[email protected]>

Cheers,

Paul

> ---
> drivers/gpu/drm/logicvc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-6.1.orig/drivers/gpu/drm/logicvc/Kconfig
> +++ linux-6.1/drivers/gpu/drm/logicvc/Kconfig
> @@ -1,7 +1,7 @@
> config DRM_LOGICVC
> tristate "LogiCVC DRM"
> depends on DRM
> - depends on OF || COMPILE_TEST
> + depends on OF
> select DRM_KMS_HELPER
> select DRM_KMS_DMA_HELPER
> select DRM_GEM_DMA_HELPER
>
>
> --
> Jean Delvare
> SUSE L3 Support

--
Paul Kocialkowski, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com


Attachments:
(No filename) (1.13 kB)
signature.asc (488.00 B)
Download all attachments