2023-01-27 16:58:40

by Andreas Kemnade

Subject: [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision

The EC firmware has a different version number than anything
defined until now.

Signed-off-by: Andreas Kemnade <[email protected]>
---
Changes in V2:
use the same formatting as the other version numbers

drivers/mfd/ntxec.c | 1 +
include/linux/mfd/ntxec.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mfd/ntxec.c b/drivers/mfd/ntxec.c
index e16a7a82a929..b02785b10d48 100644
--- a/drivers/mfd/ntxec.c
+++ b/drivers/mfd/ntxec.c
@@ -175,6 +175,7 @@ static int ntxec_probe(struct i2c_client *client)
/* Bail out if we encounter an unknown firmware version */
switch (version) {
case NTXEC_VERSION_KOBO_AURA:
+ case NTXEC_VERSION_TOLINO_VISION:
subdevs = ntxec_subdev;
n_subdevs = ARRAY_SIZE(ntxec_subdev);
break;
diff --git a/include/linux/mfd/ntxec.h b/include/linux/mfd/ntxec.h
index cc6f07bfa2b3..e5880c346da9 100644
--- a/include/linux/mfd/ntxec.h
+++ b/include/linux/mfd/ntxec.h
@@ -34,5 +34,5 @@ static inline u16 ntxec_reg8(u8 value)
/* Known firmware versions */
#define NTXEC_VERSION_KOBO_AURA 0xd726 /* found in Kobo Aura */
#define NTXEC_VERSION_TOLINO_SHINE2 0xf110 /* found in Tolino Shine 2 HD */
-
+#define NTXEC_VERSION_TOLINO_VISION 0xe135 /* found in Tolino Vision, contains RTC, ADC, PWM, home pad */
#endif
--
2.30.2

2023-01-27 17:15:56

by Lee Jones

Subject: Re: [PATCH v2] mfd: ntxec: Add version number for EC in Tolino Vision

On Fri, 27 Jan 2023, Andreas Kemnade wrote:

> The EC firmware has a different version number than anything
> defined until now.
>
> Signed-off-by: Andreas Kemnade <[email protected]>
> ---
> Changes in V2:
> use the same formatting as the other version numbers
>
> drivers/mfd/ntxec.c | 1 +
> include/linux/mfd/ntxec.h | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)

Applied, thanks

--
Lee Jones [李琼斯]