2023-01-28 08:11:38

by ye.xingchen

Subject: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

From: ye xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: ye xingchen <[email protected]>
---
drivers/input/keyboard/st-keyscan.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/input/keyboard/st-keyscan.c b/drivers/input/keyboard/st-keyscan.c
index 13735a5e8391..b6e83324f97a 100644
--- a/drivers/input/keyboard/st-keyscan.c
+++ b/drivers/input/keyboard/st-keyscan.c
@@ -125,7 +125,6 @@ static int keyscan_probe(struct platform_device *pdev)
{
struct st_keyscan *keypad_data;
struct input_dev *input_dev;
- struct resource *res;
int error;

if (!pdev->dev.of_node) {
@@ -169,8 +168,7 @@ static int keyscan_probe(struct platform_device *pdev)

input_set_drvdata(input_dev, keypad_data);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
+ keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(keypad_data->base))
return PTR_ERR(keypad_data->base);

--
2.25.1

2023-01-30 04:49:13

by Dmitry Torokhov

Subject: Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

On Sat, Jan 28, 2023 at 04:11:30PM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: ye xingchen <[email protected]>

Applied, thank you.

--
Dmitry

2023-01-30 12:19:47

by Andy Shevchenko

Subject: Re: [PATCH] Input: st-keyscan - Use devm_platform_get_and_ioremap_resource()

On Sat, Jan 28, 2023 at 04:11:30PM +0800, [email protected] wrote:
> From: ye xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.

...

> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - keypad_data->base = devm_ioremap_resource(&pdev->dev, res);
> + keypad_data->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);

Why?

What we need here is simple devm_platform_ioremap_resource().

--
With Best Regards,
Andy Shevchenko