2023-01-28 16:51:48

by Tom Rix

Subject: [PATCH] lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()

cppcheck reports
lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
size_t avail_in = avail_in = strm->avail_in;

Only setting avail_in once is needed.

Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
Signed-off-by: Tom Rix <[email protected]>
---
lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/zlib_dfltcc/dfltcc_deflate.c b/lib/zlib_dfltcc/dfltcc_deflate.c
index 80924f067c24..b732b6d9e35d 100644
--- a/lib/zlib_dfltcc/dfltcc_deflate.c
+++ b/lib/zlib_dfltcc/dfltcc_deflate.c
@@ -62,7 +62,7 @@ static void dfltcc_gdht(
{
deflate_state *state = (deflate_state *)strm->state;
struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
- size_t avail_in = avail_in = strm->avail_in;
+ size_t avail_in = strm->avail_in;

dfltcc(DFLTCC_GDHT,
param, NULL, NULL,
--
2.26.3

2023-01-29 19:07:10

by Ilya Leoshkevich

Subject: Re: [PATCH] lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()

On Sat, 2023-01-28 at 08:50 -0800, Tom Rix wrote:
> cppcheck reports
> lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment
> of 'avail_in' to itself. [selfAssignment]
>     size_t avail_in = avail_in = strm->avail_in;
>
> Only setting avail_in once is needed.
>
> Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel
> zlib_deflate")
> Signed-off-by: Tom Rix <[email protected]>
> ---
>  lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/zlib_dfltcc/dfltcc_deflate.c
> b/lib/zlib_dfltcc/dfltcc_deflate.c
> index 80924f067c24..b732b6d9e35d 100644
> --- a/lib/zlib_dfltcc/dfltcc_deflate.c
> +++ b/lib/zlib_dfltcc/dfltcc_deflate.c
> @@ -62,7 +62,7 @@ static void dfltcc_gdht(
>  {
>      deflate_state *state = (deflate_state *)strm->state;
>      struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
> -    size_t avail_in = avail_in = strm->avail_in;
> +    size_t avail_in = strm->avail_in;
>  
>      dfltcc(DFLTCC_GDHT,
>             param, NULL, NULL,

Thanks for spotting this!

Acked-by: Ilya Leoshkevich <[email protected]>

2023-01-30 09:43:21

by Zaslonko Mikhail

Subject: Re: [PATCH] lib/zlib: remove redundation assignement of avail_in dfltcc_gdht()

On 28.01.2023 17:50, Tom Rix wrote:
> cppcheck reports
> lib/zlib_dfltcc/dfltcc_deflate.c:65:21: warning: Redundant assignment of 'avail_in' to itself. [selfAssignment]
> size_t avail_in = avail_in = strm->avail_in;
>
> Only setting avail_in once is needed.
>
> Fixes: aa5b395b69b6 ("lib/zlib: add s390 hardware support for kernel zlib_deflate")
> Signed-off-by: Tom Rix <[email protected]>
> ---
> lib/zlib_dfltcc/dfltcc_deflate.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/zlib_dfltcc/dfltcc_deflate.c b/lib/zlib_dfltcc/dfltcc_deflate.c
> index 80924f067c24..b732b6d9e35d 100644
> --- a/lib/zlib_dfltcc/dfltcc_deflate.c
> +++ b/lib/zlib_dfltcc/dfltcc_deflate.c
> @@ -62,7 +62,7 @@ static void dfltcc_gdht(
> {
> deflate_state *state = (deflate_state *)strm->state;
> struct dfltcc_param_v0 *param = &GET_DFLTCC_STATE(state)->param;
> - size_t avail_in = avail_in = strm->avail_in;
> + size_t avail_in = strm->avail_in;
>
> dfltcc(DFLTCC_GDHT,
> param, NULL, NULL,

Acked-by: Mikhail Zaslonko <[email protected]>