2023-01-29 09:43:08

by Luca Weiss

Subject: [PATCH 2/4] media: i2c: ov2685: Add print for power on write failed

If the sensor doens't power up correctly, for example due to incorrect
devicetree description, the power up i2c writes will fail.

Add an error print for this situation.

Signed-off-by: Luca Weiss <[email protected]>
---
drivers/media/i2c/ov2685.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c
index a422f4c8a2eb..844a91dbc8e5 100644
--- a/drivers/media/i2c/ov2685.c
+++ b/drivers/media/i2c/ov2685.c
@@ -419,8 +419,10 @@ static int __ov2685_power_on(struct ov2685 *ov2685)
* writing register before .s_stream() as a workaround
*/
ret = ov2685_write_array(ov2685->client, ov2685->cur_mode->reg_list);
- if (ret)
+ if (ret) {
+ dev_err(dev, "Failed to set regs for power on\n");
goto disable_supplies;
+ }

return 0;


--
2.39.1

2023-01-29 11:24:24

by Jacopo Mondi

Subject: Re: [PATCH 2/4] media: i2c: ov2685: Add print for power on write failed

Hi Luca

On Sun, Jan 29, 2023 at 10:42:36AM +0100, Luca Weiss wrote:
> If the sensor doens't power up correctly, for example due to incorrect
> devicetree description, the power up i2c writes will fail.
>
> Add an error print for this situation.
>
> Signed-off-by: Luca Weiss <[email protected]>
> ---
> drivers/media/i2c/ov2685.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/media/i2c/ov2685.c b/drivers/media/i2c/ov2685.c
> index a422f4c8a2eb..844a91dbc8e5 100644
> --- a/drivers/media/i2c/ov2685.c
> +++ b/drivers/media/i2c/ov2685.c
> @@ -419,8 +419,10 @@ static int __ov2685_power_on(struct ov2685 *ov2685)
> * writing register before .s_stream() as a workaround
> */
> ret = ov2685_write_array(ov2685->client, ov2685->cur_mode->reg_list);
> - if (ret)
> + if (ret) {
> + dev_err(dev, "Failed to set regs for power on\n");
> goto disable_supplies;
> + }

This is fine. I would also consider if it's worth to fail loud in
ov2685_write_reg().

Reviewed-by: Jacopo Mondi <[email protected]>
>
> return 0;
>
>
> --
> 2.39.1
>