2023-01-29 12:37:26

by J. Neuschäfer

[permalink] [raw]
Subject: [PATCH] dt-bindings: bus: moxtet: Fix reference to SPI peripheral DT properties

spi-bus.txt has been converted to YAML and the peripheral properties
have been moved to spi-controller.yaml.

Fixes: 0a1b929356830 ("spi: Add YAML schemas for the generic SPI options")
Fixes: 8762b07c95c18 ("spi: dt-bindings: add schema listing peripheral-specific properties")
Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
Documentation/devicetree/bindings/bus/moxtet.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/bus/moxtet.txt b/Documentation/devicetree/bindings/bus/moxtet.txt
index fb50fc8653368..d6bf929c00c4e 100644
--- a/Documentation/devicetree/bindings/bus/moxtet.txt
+++ b/Documentation/devicetree/bindings/bus/moxtet.txt
@@ -11,7 +11,7 @@ Required properties:
- #interrupt-cells : Has to be 1

For other required and optional properties of SPI slave nodes please refer to
-../spi/spi-bus.txt.
+../spi/spi-peripheral-props.yaml.

Required properties of subnodes:
- reg : Should be position on the Moxtet bus (how many Moxtet
--
2.39.0



2023-01-29 12:57:23

by Marek Behún

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: bus: moxtet: Fix reference to SPI peripheral DT properties

On Sun, 29 Jan 2023 13:35:53 +0100
Jonathan Neuschäfer <[email protected]> wrote:

> spi-bus.txt has been converted to YAML and the peripheral properties
> have been moved to spi-controller.yaml.
>
> Fixes: 0a1b929356830 ("spi: Add YAML schemas for the generic SPI options")
> Fixes: 8762b07c95c18 ("spi: dt-bindings: add schema listing peripheral-specific properties")
> Signed-off-by: Jonathan Neuschäfer <[email protected]>
> ---
> Documentation/devicetree/bindings/bus/moxtet.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/bus/moxtet.txt b/Documentation/devicetree/bindings/bus/moxtet.txt
> index fb50fc8653368..d6bf929c00c4e 100644
> --- a/Documentation/devicetree/bindings/bus/moxtet.txt
> +++ b/Documentation/devicetree/bindings/bus/moxtet.txt
> @@ -11,7 +11,7 @@ Required properties:
> - #interrupt-cells : Has to be 1
>
> For other required and optional properties of SPI slave nodes please refer to
> -../spi/spi-bus.txt.
> +../spi/spi-peripheral-props.yaml.
>
> Required properties of subnodes:
> - reg : Should be position on the Moxtet bus (how many Moxtet
> --
> 2.39.0
>

Acked-by: Marek Behún <[email protected]>

2023-01-30 22:16:32

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: bus: moxtet: Fix reference to SPI peripheral DT properties

On Sun, Jan 29, 2023 at 01:35:53PM +0100, Jonathan Neusch?fer wrote:
> spi-bus.txt has been converted to YAML and the peripheral properties
> have been moved to spi-controller.yaml.
>
> Fixes: 0a1b929356830 ("spi: Add YAML schemas for the generic SPI options")
> Fixes: 8762b07c95c18 ("spi: dt-bindings: add schema listing peripheral-specific properties")
> Signed-off-by: Jonathan Neusch?fer <[email protected]>
> ---
> Documentation/devicetree/bindings/bus/moxtet.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

I'm not really interested in fixes to .txt bindings. Fix it by
converting to schema if you want to. By my count, there's 37 other
cases, why just this one?

Rob

2023-01-31 20:53:52

by J. Neuschäfer

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: bus: moxtet: Fix reference to SPI peripheral DT properties

On Mon, Jan 30, 2023 at 04:16:26PM -0600, Rob Herring wrote:
> On Sun, Jan 29, 2023 at 01:35:53PM +0100, Jonathan Neuschäfer wrote:
> > spi-bus.txt has been converted to YAML and the peripheral properties
> > have been moved to spi-controller.yaml.
> >
> > Fixes: 0a1b929356830 ("spi: Add YAML schemas for the generic SPI options")
> > Fixes: 8762b07c95c18 ("spi: dt-bindings: add schema listing peripheral-specific properties")
> > Signed-off-by: Jonathan Neuschäfer <[email protected]>
> > ---
> > Documentation/devicetree/bindings/bus/moxtet.txt | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> I'm not really interested in fixes to .txt bindings. Fix it by
> converting to schema if you want to.

Fair enough.

> By my count, there's 37 other cases, why just this one?

Mainly because a patch to a large number of files seemed harder to
coordinate well.


Jonathan


Attachments:
(No filename) (892.00 B)
signature.asc (833.00 B)
Download all attachments