2023-01-29 16:01:20

by Jonathan Neuschäfer

[permalink] [raw]
Subject: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM

A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
that is already the case with DEBUG_LL=y (and documented in its help
text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
think users need to be prevented from enabling DEBUG_UNCOMPRESS on
ARCH_MULTIPLATFORM kernels.

Signed-off-by: Jonathan Neuschäfer <[email protected]>
---
arch/arm/Kconfig.debug | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug
index c345775f035bc..655f84ada30f4 100644
--- a/arch/arm/Kconfig.debug
+++ b/arch/arm/Kconfig.debug
@@ -1904,7 +1904,6 @@ config DEBUG_UART_8250_PALMCHIP

config DEBUG_UNCOMPRESS
bool "Enable decompressor debugging via DEBUG_LL output"
- depends on !ARCH_MULTIPLATFORM
depends on !(ARCH_FOOTBRIDGE || ARCH_RPC || ARCH_SA1100)
depends on DEBUG_LL && !DEBUG_OMAP2PLUS_UART && \
(!DEBUG_TEGRA_UART || !ZBOOT_ROM) && \
--
2.39.0



2023-01-30 08:11:24

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH] ARM: Allow DEBUG_UNCOMPRESS on ARCH_MULTIPLATFORM

On Sun, Jan 29, 2023, at 17:00, Jonathan Neuschäfer wrote:
> A kernel with DEBUG_UNCOMPRESS=y will only work on one platform, but
> that is already the case with DEBUG_LL=y (and documented in its help
> text), and DEBUG_UNCOMPRESS depends on DEBUG_LL. Therefore, I don't
> think users need to be prevented from enabling DEBUG_UNCOMPRESS on
> ARCH_MULTIPLATFORM kernels.
>
> Signed-off-by: Jonathan Neuschäfer <[email protected]>

I think we should instead change the help text for CONFIG_DEBUG_LL.

There is a very significant difference between the requirements
of DEBUG_LL compared to DEBUG_UNCOMPRESS. The former only provides
the platform specific functions but does not call them unless
a user explicitly passes the "earlyprintk" command line argument
or adds explicit function calls to printascii(), while the latter
makes the kernel immediately unbootable.

Arnd