2023-01-30 06:45:07

by Hermes Zhang

Subject: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

Add a new property: cap-aggressive-pm to enable the
MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Signed-off-by: Hermes Zhang <[email protected]>
---

Notes:
Update commit message

Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
index 86c73fd825fd..7ca674263dba 100644
--- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
+++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
@@ -177,6 +177,11 @@ properties:
description:
enable SDIO IRQ signalling on this interface

+ cap-aggressive-pm:
+ $ref: /schemas/types.yaml#/definitions/flag
+ description:
+ enable MMC_CAP_AGGRESSIVE_PM feature
+
full-pwr-cycle:
$ref: /schemas/types.yaml#/definitions/flag
description:
--
2.30.2

2023-01-30 22:44:17

by Rob Herring

Subject: Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

On Mon, Jan 30, 2023 at 02:44:33PM +0800, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.

Is that a kernel feature or something from the MMC or SD specifications?
The former doesn't belong in DT. Set this based on the compatible string
of the controller.

>
> Signed-off-by: Hermes Zhang <[email protected]>
> ---
>
> Notes:
> Update commit message
>
> Documentation/devicetree/bindings/mmc/mmc-controller.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> index 86c73fd825fd..7ca674263dba 100644
> --- a/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> +++ b/Documentation/devicetree/bindings/mmc/mmc-controller.yaml
> @@ -177,6 +177,11 @@ properties:
> description:
> enable SDIO IRQ signalling on this interface
>
> + cap-aggressive-pm:
> + $ref: /schemas/types.yaml#/definitions/flag
> + description:
> + enable MMC_CAP_AGGRESSIVE_PM feature
> +
> full-pwr-cycle:
> $ref: /schemas/types.yaml#/definitions/flag
> description:
> --
> 2.30.2
>

2023-01-31 19:16:54

by Krzysztof Kozlowski

Subject: Re: [PATCH v2] dt-bindings: mmc: Add cap-aggressive-pm property

On 30/01/2023 07:44, Hermes Zhang wrote:
> Add a new property: cap-aggressive-pm to enable the
> MMC_CAP_AGGRESSIVE_PM feature for (e)MMC/SD power saving.
>
> Signed-off-by: Hermes Zhang <[email protected]>


We did not finish discussion from v1 as you did not really answer my
concerns there. Don't send v2 because it looks like you cut the
discussion and ignore the feedback.

Best regards,
Krzysztof