2023-01-30 13:56:03

by Arnd Bergmann

Subject: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning

From: Arnd Bergmann <[email protected]>

In one of the clocks, a redundant initialization for .num_parents
got left behind by a recent patch:

drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
63 | .num_parents = 1,
| ^

Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/clk/qcom/gcc-qcs404.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
index 5f58dd82d3fe..a39c4990b29d 100644
--- a/drivers/clk/qcom/gcc-qcs404.c
+++ b/drivers/clk/qcom/gcc-qcs404.c
@@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
.name = "cxo",
.parent_data = gcc_parent_data_1,
.num_parents = ARRAY_SIZE(gcc_parent_data_1),
- .num_parents = 1,
.ops = &clk_fixed_factor_ops,
},
};
--
2.39.0

2023-01-30 13:56:47

by Konrad Dybcio

Subject: Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning

On 30.01.2023 14:55, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
> drivers/clk/qcom/gcc-qcs404.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/clk/qcom/gcc-qcs404.c b/drivers/clk/qcom/gcc-qcs404.c
> index 5f58dd82d3fe..a39c4990b29d 100644
> --- a/drivers/clk/qcom/gcc-qcs404.c
> +++ b/drivers/clk/qcom/gcc-qcs404.c
> @@ -60,7 +60,6 @@ static struct clk_fixed_factor cxo = {
> .name = "cxo",
> .parent_data = gcc_parent_data_1,
> .num_parents = ARRAY_SIZE(gcc_parent_data_1),
> - .num_parents = 1,
> .ops = &clk_fixed_factor_ops,
> },
> };

2023-01-30 22:30:27

by Stephen Boyd

Subject: Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning

Quoting Arnd Bergmann (2023-01-30 05:55:47)
> From: Arnd Bergmann <[email protected]>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> Fixes: 2ce81afa0c7c ("clk: qcom: gcc-qcs404: sort out the cxo clock")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

This is https://lore.kernel.org/r/[email protected]

2023-01-30 23:46:36

by Bjorn Andersson

Subject: Re: [PATCH] clk: qcom: gcc-qcs404: fix duplicate initializer warning

On Mon, 30 Jan 2023 14:55:47 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> In one of the clocks, a redundant initialization for .num_parents
> got left behind by a recent patch:
>
> drivers/clk/qcom/gcc-qcs404.c:63:32: error: initialized field overwritten [-Werror=override-init]
> 63 | .num_parents = 1,
> | ^
>
> [...]

Applied, thanks!

[1/1] clk: qcom: gcc-qcs404: fix duplicate initializer warning
commit: d4cb3e7113f82f7378527890aa7b4006234665fe

Best regards,
--
Bjorn Andersson <[email protected]>