2023-01-30 20:04:08

by Chris Healy

Subject: [PATCH v2] net: phy: meson-gxl: Add generic dummy stubs for MMD register access

From: Chris Healy <[email protected]>

The Meson G12A Internal PHY does not support standard IEEE MMD extended
register access, therefore add generic dummy stubs to fail the read and
write MMD calls. This is necessary to prevent the core PHY code from
erroneously believing that EEE is supported by this PHY even though this
PHY does not support EEE, as MMD register access returns all FFFFs.

Fixes: 5c3407abb338 ("net: phy: meson-gxl: add g12a support")
Signed-off-by: Chris Healy <[email protected]>
---

Change in v2:
* Add fixes tag

drivers/net/phy/meson-gxl.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/net/phy/meson-gxl.c b/drivers/net/phy/meson-gxl.c
index c49062ad72c6..5e41658b1e2f 100644
--- a/drivers/net/phy/meson-gxl.c
+++ b/drivers/net/phy/meson-gxl.c
@@ -271,6 +271,8 @@ static struct phy_driver meson_gxl_phy[] = {
.handle_interrupt = meson_gxl_handle_interrupt,
.suspend = genphy_suspend,
.resume = genphy_resume,
+ .read_mmd = genphy_read_mmd_unsupported,
+ .write_mmd = genphy_write_mmd_unsupported,
},
};

--
2.39.1

2023-01-30 20:16:21

by Heiner Kallweit

Subject: Re: [PATCH v2] net: phy: meson-gxl: Add generic dummy stubs for MMD register access

On 30.01.2023 21:03, Chris Healy wrote:
> From: Chris Healy <[email protected]>
>
> The Meson G12A Internal PHY does not support standard IEEE MMD extended
> register access, therefore add generic dummy stubs to fail the read and
> write MMD calls. This is necessary to prevent the core PHY code from
> erroneously believing that EEE is supported by this PHY even though this
> PHY does not support EEE, as MMD register access returns all FFFFs.
>
> Fixes: 5c3407abb338 ("net: phy: meson-gxl: add g12a support")
> Signed-off-by: Chris Healy <[email protected]>
> ---
>
> Change in v2:
> * Add fixes tag
>
Reviewed-by: Heiner Kallweit <[email protected]>