Bindings expect pins to be named with certain pattern.
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Endless work... People keep sending patches without running dtbs_check
faster than I am fixing existing warnings.
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index df841230d1b7..ece1a7cb8b3b 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
};
lt9611_state: lt9611-state {
- rst {
+ rst-pins {
pins = "gpio48";
function = "normal";
@@ -731,7 +731,7 @@ rst {
input-disable;
};
- irq {
+ irq-pins {
pins = "gpio50";
function = "gpio";
bias-disable;
--
2.34.1
SM8350 pin controller does not have "normal" pin function, so use
"gpio".
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
index ece1a7cb8b3b..8b7cc45b0919 100644
--- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
+++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
@@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
lt9611_state: lt9611-state {
rst-pins {
pins = "gpio48";
- function = "normal";
+ function = "gpio";
output-high;
input-disable;
--
2.34.1
The SM8350 HDK8350 board uses input-disable property, so allow it:
sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
...
'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
index 49a74f351e99..e13d50d6d388 100644
--- a/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
+++ b/Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml
@@ -109,6 +109,7 @@ $defs:
bias-pull-down: true
bias-pull-up: true
drive-strength: true
+ input-disable: true
input-enable: true
output-high: true
output-low: true
--
2.34.1
On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Do we want a Fixes: here?
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
>
> Endless work... People keep sending patches without running dtbs_check
> faster than I am fixing existing warnings.
> ---
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index df841230d1b7..ece1a7cb8b3b 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -723,7 +723,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> };
>
> lt9611_state: lt9611-state {
> - rst {
> + rst-pins {
> pins = "gpio48";
> function = "normal";
>
> @@ -731,7 +731,7 @@ rst {
> input-disable;
> };
>
> - irq {
> + irq-pins {
> pins = "gpio50";
> function = "gpio";
> bias-disable;
On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
> SM8350 pin controller does not have "normal" pin function, so use
> "gpio".
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
Makes one wonder if it was ever tested, as this would have probably
failed when setting pinctrl settings..
Reviewed-by: Konrad Dybcio <[email protected]>
Konrad
> arch/arm64/boot/dts/qcom/sm8350-hdk.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> index ece1a7cb8b3b..8b7cc45b0919 100644
> --- a/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8350-hdk.dts
> @@ -725,7 +725,7 @@ usb_hub_enabled_state: usb-hub-enabled-state {
> lt9611_state: lt9611-state {
> rst-pins {
> pins = "gpio48";
> - function = "normal";
> + function = "gpio";
>
> output-high;
> input-disable;
On 01/02/2023 16:47, Konrad Dybcio wrote:
>
>
> On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
>> SM8350 pin controller does not have "normal" pin function, so use
>> "gpio".
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>> ---
> Makes one wonder if it was ever tested, as this would have probably
> failed when setting pinctrl settings..
>
> Reviewed-by: Konrad Dybcio <[email protected]>
Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge")
Best regards,
Krzysztof
On 01/02/2023 16:46, Konrad Dybcio wrote:
>
>
> On 1.02.2023 16:43, Krzysztof Kozlowski wrote:
>> Bindings expect pins to be named with certain pattern.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> ---
> Do we want a Fixes: here?
>
> Reviewed-by: Konrad Dybcio <[email protected]>
Could be:
Fixes: d96d8f9192be ("arm64: dts: qcom: sm8350-hdk: Enable lt9611uxc dsi-hdmi bridge")
Best regards,
Krzysztof
On Wed, 01 Feb 2023 16:43:21 +0100, Krzysztof Kozlowski wrote:
> The SM8350 HDK8350 board uses input-disable property, so allow it:
>
> sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
> ...
> 'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
> ---
> Documentation/devicetree/bindings/pinctrl/qcom,sm8350-tlmm.yaml | 1 +
> 1 file changed, 1 insertion(+)
>
Acked-by: Rob Herring <[email protected]>
On Wed, 1 Feb 2023 16:43:21 +0100, Krzysztof Kozlowski wrote:
> The SM8350 HDK8350 board uses input-disable property, so allow it:
>
> sm8350-hdk.dtb: pinctrl@f100000: lt9611-state: 'oneOf' conditional failed, one must be fixed:
> ...
> 'input-disable' does not match any of the regexes: 'pinctrl-[0-9]+'
>
>
> [...]
Applied, thanks!
[3/3] dt-bindings: pinctrl: qcom,sm8350: add input-disable
https://git.kernel.org/krzk/linux-dt/c/91d04c759c85f1fc2d3ed7d1b5bc1a7dbab87f92
Best regards,
--
Krzysztof Kozlowski <[email protected]>
On Wed, 1 Feb 2023 16:43:19 +0100, Krzysztof Kozlowski wrote:
> Bindings expect pins to be named with certain pattern.
>
>
Applied, thanks!
[1/3] arm64: dts: qcom: sm8350-hdk: align pin config node names with bindings
commit: 9927f8a59f42b6c0bde9ba770ffe9d9d9bce79da
[2/3] arm64: dts: qcom: sm8350-hdk: correct LT9611 pin function
commit: cd06d923304355762d426b030a30d99fdf765b84
Best regards,
--
Bjorn Andersson <[email protected]>