2023-02-07 18:27:14

by Pietro Borrello

Subject: [PATCH net v3] rds: rds_rm_zerocopy_callback() use list_first_entry()

rds_rm_zerocopy_callback() uses list_entry() on the head of a list
causing a type confusion.
Use list_first_entry() to actually access the first element of the
rs_zcookie_queue list.

Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
Reviewed-by: Willem de Bruijn <[email protected]>
Signed-off-by: Pietro Borrello <[email protected]>
---
Changes in v3:
- target net
- Link to v2: https://lore.kernel.org/r/[email protected]
---
net/rds/message.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/net/rds/message.c b/net/rds/message.c
index b47e4f0a1639..c19c93561227 100644
--- a/net/rds/message.c
+++ b/net/rds/message.c
@@ -104,9 +104,9 @@ static void rds_rm_zerocopy_callback(struct rds_sock *rs,
spin_lock_irqsave(&q->lock, flags);
head = &q->zcookie_head;
if (!list_empty(head)) {
- info = list_entry(head, struct rds_msg_zcopy_info,
- rs_zcookie_next);
- if (info && rds_zcookie_add(info, cookie)) {
+ info = list_first_entry(head, struct rds_msg_zcopy_info,
+ rs_zcookie_next);
+ if (rds_zcookie_add(info, cookie)) {
spin_unlock_irqrestore(&q->lock, flags);
kfree(rds_info_from_znotifier(znotif));
/* caller invokes rds_wake_sk_sleep() */

---
base-commit: 6d796c50f84ca79f1722bb131799e5a5710c4700
change-id: 20230202-rds-zerocopy-be99b84131c8

Best regards,
--
Pietro Borrello <[email protected]>

2023-02-09 09:50:33

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net v3] rds: rds_rm_zerocopy_callback() use list_first_entry()

Hello:

This patch was applied to netdev/net.git (master)
by Paolo Abeni <[email protected]>:

On Tue, 07 Feb 2023 18:26:34 +0000 you wrote:
> rds_rm_zerocopy_callback() uses list_entry() on the head of a list
> causing a type confusion.
> Use list_first_entry() to actually access the first element of the
> rs_zcookie_queue list.
>
> Fixes: 9426bbc6de99 ("rds: use list structure to track information for zerocopy completion notification")
> Reviewed-by: Willem de Bruijn <[email protected]>
> Signed-off-by: Pietro Borrello <[email protected]>
>
> [...]

Here is the summary with links:
- [net,v3] rds: rds_rm_zerocopy_callback() use list_first_entry()
https://git.kernel.org/netdev/net/c/f753a68980cf

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html