2023-01-31 09:47:23

by Arnd Bergmann

[permalink] [raw]
Subject: [PATCH] iio: adis16480: select CONFIG_CRC32

From: Arnd Bergmann <[email protected]>

In rare randconfig builds, the missing CRC32 helper causes
a link error:

ld.lld: error: undefined symbol: crc32_le
>>> referenced by usercopy_64.c
>>> vmlinux.o:(adis16480_trigger_handler)

Fixes: 941f130881fa ("iio: adis16480: support burst read function")
Signed-off-by: Arnd Bergmann <[email protected]>
---
drivers/iio/imu/Kconfig | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/iio/imu/Kconfig b/drivers/iio/imu/Kconfig
index f1d7d4b5e222..c2f97629e9cd 100644
--- a/drivers/iio/imu/Kconfig
+++ b/drivers/iio/imu/Kconfig
@@ -47,6 +47,7 @@ config ADIS16480
depends on SPI
select IIO_ADIS_LIB
select IIO_ADIS_LIB_BUFFER if IIO_BUFFER
+ select CRC32
help
Say yes here to build support for Analog Devices ADIS16375, ADIS16480,
ADIS16485, ADIS16488 inertial sensors.
--
2.39.0



2023-01-31 10:21:34

by Nuno Sá

[permalink] [raw]
Subject: Re: [PATCH] iio: adis16480: select CONFIG_CRC32

On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <[email protected]>
>
> In rare randconfig builds, the missing CRC32 helper causes
> a link error:
>
> ld.lld: error: undefined symbol: crc32_le
> > > > referenced by usercopy_64.c
> > > >               vmlinux.o:(adis16480_trigger_handler)
>
> Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> Signed-off-by: Arnd Bergmann <[email protected]>
> ---

Reviewed-by: Nuno Sá <[email protected]>



2023-02-02 16:48:20

by Jonathan Cameron

[permalink] [raw]
Subject: Re: [PATCH] iio: adis16480: select CONFIG_CRC32

On Tue, 31 Jan 2023 11:23:10 +0100
Nuno Sá <[email protected]> wrote:

> On Tue, 2023-01-31 at 10:46 +0100, Arnd Bergmann wrote:
> > From: Arnd Bergmann <[email protected]>
> >
> > In rare randconfig builds, the missing CRC32 helper causes
> > a link error:
> >
> > ld.lld: error: undefined symbol: crc32_le
> > > > > referenced by usercopy_64.c
> > > > >               vmlinux.o:(adis16480_trigger_handler)
> >
> > Fixes: 941f130881fa ("iio: adis16480: support burst read function")
> > Signed-off-by: Arnd Bergmann <[email protected]>
> > ---
>
> Reviewed-by: Nuno Sá <[email protected]>
>
>
Applied to the fixes-togreg branch of iio.git and marked
for stable.

Thanks,

Jonathan