2023-02-04 20:10:02

by Tom Rix

[permalink] [raw]
Subject: [PATCH] net: wireless: zd1211rw: remove redundant decls

building with W=2 has these errors
redundant redeclaration of ‘zd_rf_generic_patch_6m’ [-Werror=redundant-decls]
redundant redeclaration of ‘zd_rf_patch_6m_band_edge’ [-Werror=redundant-decls]

Remove the second decls.

Signed-off-by: Tom Rix <[email protected]>
---
drivers/net/wireless/zydas/zd1211rw/zd_rf.h | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/wireless/zydas/zd1211rw/zd_rf.h b/drivers/net/wireless/zydas/zd1211rw/zd_rf.h
index 8bfec9e75125..9ca69df3d288 100644
--- a/drivers/net/wireless/zydas/zd1211rw/zd_rf.h
+++ b/drivers/net/wireless/zydas/zd1211rw/zd_rf.h
@@ -85,9 +85,6 @@ static inline int zd_rf_should_patch_cck_gain(struct zd_rf *rf)
return rf->patch_cck_gain;
}

-int zd_rf_patch_6m_band_edge(struct zd_rf *rf, u8 channel);
-int zd_rf_generic_patch_6m(struct zd_rf *rf, u8 channel);
-
/* Functions for individual RF chips */

int zd_rf_init_rf2959(struct zd_rf *rf);
--
2.26.3



2023-02-05 13:31:09

by Simon Horman

[permalink] [raw]
Subject: Re: [PATCH] net: wireless: zd1211rw: remove redundant decls

On Sat, Feb 04, 2023 at 12:09:02PM -0800, Tom Rix wrote:
> building with W=2 has these errors
> redundant redeclaration of ‘zd_rf_generic_patch_6m’ [-Werror=redundant-decls]
> redundant redeclaration of ‘zd_rf_patch_6m_band_edge’ [-Werror=redundant-decls]
>
> Remove the second decls.
>
> Signed-off-by: Tom Rix <[email protected]>

Reviewed-by: Simon Horman <[email protected]>


2023-02-13 17:26:31

by Kalle Valo

[permalink] [raw]
Subject: Re: wifi: zd1211rw: remove redundant decls

Tom Rix <[email protected]> wrote:

> building with W=2 has these errors
> redundant redeclaration of ‘zd_rf_generic_patch_6m’ [-Werror=redundant-decls]
> redundant redeclaration of ‘zd_rf_patch_6m_band_edge’ [-Werror=redundant-decls]
>
> Remove the second decls.
>
> Signed-off-by: Tom Rix <[email protected]>
> Reviewed-by: Simon Horman <[email protected]>

Patch applied to wireless-next.git, thanks.

9d5dbfe0e170 wifi: zd1211rw: remove redundant decls

--
https://patchwork.kernel.org/project/linux-wireless/patch/[email protected]/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches