2023-02-08 07:39:42

by ye.xingchen

Subject: [PATCH] bus: vexpress-config: use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/bus/vexpress-config.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/bus/vexpress-config.c b/drivers/bus/vexpress-config.c
index a58ac0c8e282..a03c9e32a665 100644
--- a/drivers/bus/vexpress-config.c
+++ b/drivers/bus/vexpress-config.c
@@ -350,7 +350,6 @@ static struct vexpress_config_bridge_ops vexpress_syscfg_bridge_ops = {
static int vexpress_syscfg_probe(struct platform_device *pdev)
{
struct vexpress_syscfg *syscfg;
- struct resource *res;
struct vexpress_config_bridge *bridge;
struct device_node *node;
int master;
@@ -362,8 +361,7 @@ static int vexpress_syscfg_probe(struct platform_device *pdev)
syscfg->dev = &pdev->dev;
INIT_LIST_HEAD(&syscfg->funcs);

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- syscfg->base = devm_ioremap_resource(&pdev->dev, res);
+ syscfg->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(syscfg->base))
return PTR_ERR(syscfg->base);

--
2.25.1

2023-02-08 11:59:44

by Sudeep Holla

Subject: Re: [PATCH] bus: vexpress-config: use devm_platf orm_get_and_ioremap_resource()

On Wed, Feb 08, 2023 at 03:38:54PM +0800, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>

LGTM,

Acked-by: Sudeep Holla <[email protected]>

Not sure if you plan to take all such changes together or you want individual
patches to be picked up by respective maintainers, let me know.

--
Regards,
Sudeep