2023-02-08 08:36:05

by ye.xingchen

Subject: [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/media/platform/nxp/dw100/dw100.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 189d60cd5ed1..0771a88122c0 100644
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
{
struct dw100_device *dw_dev;
struct video_device *vfd;
- struct resource *res;
int ret, irq;

dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
@@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
}
dw_dev->num_clks = ret;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
+ dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(dw_dev->mmio))
return PTR_ERR(dw_dev->mmio);

--
2.25.1

2023-02-08 10:12:22

by Xavier Roumegue (OSS)

Subject: Re: [PATCH] media: dw100: use devm_platform_get_and_ioremap_resource()

Hi Ye Xingchen,

Thanks for your patch.

On 2/8/23 09:35, [email protected] wrote:
> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Reviewed-by: Xavier Roumegue <[email protected]>

Regards,
Xavier

> ---
> drivers/media/platform/nxp/dw100/dw100.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
> index 189d60cd5ed1..0771a88122c0 100644
> --- a/drivers/media/platform/nxp/dw100/dw100.c
> +++ b/drivers/media/platform/nxp/dw100/dw100.c
> @@ -1532,7 +1532,6 @@ static int dw100_probe(struct platform_device *pdev)
> {
> struct dw100_device *dw_dev;
> struct video_device *vfd;
> - struct resource *res;
> int ret, irq;
>
> dw_dev = devm_kzalloc(&pdev->dev, sizeof(*dw_dev), GFP_KERNEL);
> @@ -1547,8 +1546,7 @@ static int dw100_probe(struct platform_device *pdev)
> }
> dw_dev->num_clks = ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - dw_dev->mmio = devm_ioremap_resource(&pdev->dev, res);
> + dw_dev->mmio = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(dw_dev->mmio))
> return PTR_ERR(dw_dev->mmio);
>