2023-02-08 09:32:51

by ye.xingchen

Subject: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/mfd/atmel-flexcom.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
index 33caa4fba6af..b52f7ffdad35 100644
--- a/drivers/mfd/atmel-flexcom.c
+++ b/drivers/mfd/atmel-flexcom.c
@@ -37,7 +37,6 @@ struct atmel_flexcom {
static int atmel_flexcom_probe(struct platform_device *pdev)
{
struct device_node *np = pdev->dev.of_node;
- struct resource *res;
struct atmel_flexcom *ddata;
int err;

@@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
return -EINVAL;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- ddata->base = devm_ioremap_resource(&pdev->dev, res);
+ ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(ddata->base))
return PTR_ERR(ddata->base);

--
2.25.1

2023-02-08 09:49:59

by Claudiu Beznea

Subject: Re: [PATCH] mfd: atmel-flexcom: use devm_pla tform_get_and_ioremap_resource()

On 08.02.2023 11:31, [email protected] wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>
Tested-by: Claudiu Beznea <[email protected]>

> ---
> drivers/mfd/atmel-flexcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/mfd/atmel-flexcom.c b/drivers/mfd/atmel-flexcom.c
> index 33caa4fba6af..b52f7ffdad35 100644
> --- a/drivers/mfd/atmel-flexcom.c
> +++ b/drivers/mfd/atmel-flexcom.c
> @@ -37,7 +37,6 @@ struct atmel_flexcom {
> static int atmel_flexcom_probe(struct platform_device *pdev)
> {
> struct device_node *np = pdev->dev.of_node;
> - struct resource *res;
> struct atmel_flexcom *ddata;
> int err;
>
> @@ -55,8 +54,7 @@ static int atmel_flexcom_probe(struct platform_device *pdev)
> ddata->opmode > ATMEL_FLEXCOM_MODE_TWI)
> return -EINVAL;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - ddata->base = devm_ioremap_resource(&pdev->dev, res);
> + ddata->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(ddata->base))
> return PTR_ERR(ddata->base);
>
> --
> 2.25.1

2023-03-03 08:23:03

by Lee Jones

Subject: Re: [PATCH] mfd: atmel-flexcom: use devm_platform_get_and_ioremap_resource()

On Wed, 08 Feb 2023, [email protected] wrote:

> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> drivers/mfd/atmel-flexcom.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]