2023-02-08 09:34:10

by ye.xingchen

Subject: [PATCH] mfd: hi6421-pmic: use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/mfd/hi6421-pmic-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/hi6421-pmic-core.c b/drivers/mfd/hi6421-pmic-core.c
index eba88b80d969..cb5cf4a81c06 100644
--- a/drivers/mfd/hi6421-pmic-core.c
+++ b/drivers/mfd/hi6421-pmic-core.c
@@ -50,7 +50,6 @@ MODULE_DEVICE_TABLE(of, of_hi6421_pmic_match);
static int hi6421_pmic_probe(struct platform_device *pdev)
{
struct hi6421_pmic *pmic;
- struct resource *res;
const struct of_device_id *id;
const struct mfd_cell *subdevs;
enum hi6421_type type;
@@ -66,8 +65,7 @@ static int hi6421_pmic_probe(struct platform_device *pdev)
if (!pmic)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- base = devm_ioremap_resource(&pdev->dev, res);
+ base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(base))
return PTR_ERR(base);

--
2.25.1

2023-03-03 08:20:35

by Lee Jones

Subject: Re: [PATCH] mfd: hi6421-pmic: use devm_platform_get_and_ioremap_resource()

On Wed, 08 Feb 2023, [email protected] wrote:

> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> drivers/mfd/hi6421-pmic-core.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Next time, could you please submit these as a set? It makes it easier
to apply them than having lots of completely separate patches.

Applied, thanks

--
Lee Jones [李琼斯]