2023-02-08 09:34:46

by ye.xingchen

[permalink] [raw]
Subject: [PATCH] mfd: ipaq-micro: use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/mfd/ipaq-micro.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/mfd/ipaq-micro.c b/drivers/mfd/ipaq-micro.c
index 4cd5ecc72211..6d3968458e81 100644
--- a/drivers/mfd/ipaq-micro.c
+++ b/drivers/mfd/ipaq-micro.c
@@ -381,7 +381,6 @@ static int __maybe_unused micro_resume(struct device *dev)
static int __init micro_probe(struct platform_device *pdev)
{
struct ipaq_micro *micro;
- struct resource *res;
int ret;
int irq;

@@ -391,8 +390,7 @@ static int __init micro_probe(struct platform_device *pdev)

micro->dev = &pdev->dev;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- micro->base = devm_ioremap_resource(&pdev->dev, res);
+ micro->base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(micro->base))
return PTR_ERR(micro->base);

--
2.25.1


2023-03-03 08:20:51

by Lee Jones

[permalink] [raw]
Subject: Re: [PATCH] mfd: ipaq-micro: use devm_platform_get_and_ioremap_resource()

On Wed, 08 Feb 2023, [email protected] wrote:

> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>
> ---
> drivers/mfd/ipaq-micro.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)

Applied, thanks

--
Lee Jones [李琼斯]