2023-02-09 01:41:01

by Kunihiko Hayashi

Subject: [PATCH] dt-bindings: ata: Add UniPhier controller binding

Add UniPhier SATA controller compatible string to the platform binding.
This controller needs two reset controls.

Signed-off-by: Kunihiko Hayashi <[email protected]>
---
Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
index 7dc2a2e8f598..3f6b21032d02 100644
--- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
+++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
@@ -45,6 +45,9 @@ properties:
- marvell,armada-8k-ahci
- marvell,berlin2-ahci
- marvell,berlin2q-ahci
+ - socionext,uniphier-pro4-ahci
+ - socionext,uniphier-pxs2-ahci
+ - socionext,uniphier-pxs3-ahci
- const: generic-ahci
- enum:
- cavium,octeon-7130-ahci
@@ -74,7 +77,8 @@ properties:
maxItems: 1

resets:
- maxItems: 1
+ minItems: 1
+ maxItems: 2

patternProperties:
"^sata-port@[0-9a-f]+$":
--
2.25.1

2023-02-09 08:51:22

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: ata: Add UniPhier controller binding

On 09/02/2023 02:40, Kunihiko Hayashi wrote:
> Add UniPhier SATA controller compatible string to the platform binding.
> This controller needs two reset controls.
>
> Signed-off-by: Kunihiko Hayashi <[email protected]>
> ---
> Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> index 7dc2a2e8f598..3f6b21032d02 100644
> --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
> @@ -45,6 +45,9 @@ properties:
> - marvell,armada-8k-ahci
> - marvell,berlin2-ahci
> - marvell,berlin2q-ahci
> + - socionext,uniphier-pro4-ahci
> + - socionext,uniphier-pxs2-ahci
> + - socionext,uniphier-pxs3-ahci
> - const: generic-ahci
> - enum:
> - cavium,octeon-7130-ahci
> @@ -74,7 +77,8 @@ properties:
> maxItems: 1
>
> resets:
> - maxItems: 1
> + minItems: 1
> + maxItems: 2

You now allow two resets for each other platform, which is not justified
in commit msg. Constrain it per device/compatible.

Best regards,
Krzysztof

2023-02-09 11:31:59

by Kunihiko Hayashi

Subject: Re: [PATCH] dt-bindings: ata: Add UniPhier controller binding

Hi Krzysztof,

Thank you for reviewing.

On 2023/02/09 17:51, Krzysztof Kozlowski wrote:
> On 09/02/2023 02:40, Kunihiko Hayashi wrote:
>> Add UniPhier SATA controller compatible string to the platform binding.
>> This controller needs two reset controls.
>>
>> Signed-off-by: Kunihiko Hayashi <[email protected]>
>> ---
>> Documentation/devicetree/bindings/ata/ahci-platform.yaml | 6 +++++-
>> 1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> index 7dc2a2e8f598..3f6b21032d02 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.yaml
>> @@ -45,6 +45,9 @@ properties:
>> - marvell,armada-8k-ahci
>> - marvell,berlin2-ahci
>> - marvell,berlin2q-ahci
>> + - socionext,uniphier-pro4-ahci
>> + - socionext,uniphier-pxs2-ahci
>> + - socionext,uniphier-pxs3-ahci
>> - const: generic-ahci
>> - enum:
>> - cavium,octeon-7130-ahci
>> @@ -74,7 +77,8 @@ properties:
>> maxItems: 1
>>
>> resets:
>> - maxItems: 1
>> + minItems: 1
>> + maxItems: 2
>
> You now allow two resets for each other platform, which is not justified
> in commit msg. Constrain it per device/compatible.

Ah I see.
I'll add if-then clause to constrain compatible instead of changing that
directly.

Thank you,

---
Best Regards
Kunihiko Hayashi