2023-02-09 16:24:27

by Matthias Brugger

Subject: [PATCH] soc: mediatek: mtk-svs: delete node name check

From: Matthias Brugger <[email protected]>

The function svs_add_device_link is called only internally from the SoC
specific probe functions. We don't need to check if the node_name is
null because that would mean that we have a buggy SoC probe function in
the first place.

Signed-off-by: Matthias Brugger <[email protected]>
---

drivers/soc/mediatek/mtk-svs.c | 5 -----
1 file changed, 5 deletions(-)

diff --git a/drivers/soc/mediatek/mtk-svs.c b/drivers/soc/mediatek/mtk-svs.c
index 299f580847bdc..a7eb019b5157d 100644
--- a/drivers/soc/mediatek/mtk-svs.c
+++ b/drivers/soc/mediatek/mtk-svs.c
@@ -2027,11 +2027,6 @@ static struct device *svs_add_device_link(struct svs_platform *svsp,
struct device *dev;
struct device_link *sup_link;

- if (!node_name) {
- dev_err(svsp->dev, "node name cannot be null\n");
- return ERR_PTR(-EINVAL);
- }
-
dev = svs_get_subsys_device(svsp, node_name);
if (IS_ERR(dev))
return dev;
--
2.39.0

2023-02-10 12:01:31

by AngeloGioacchino Del Regno

Subject: Re: [PATCH] soc: mediatek: mtk-svs: delete node name check

Il 09/02/23 17:24, [email protected] ha scritto:
> From: Matthias Brugger <[email protected]>
>
> The function svs_add_device_link is called only internally from the SoC
> specific probe functions. We don't need to check if the node_name is
> null because that would mean that we have a buggy SoC probe function in
> the first place.
>
> Signed-off-by: Matthias Brugger <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-02-11 11:37:32

by Roger Lu

Subject: Re: [PATCH] soc: mediatek: mtk-svs: delete node name check

On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote:
> Il 09/02/23 17:24, [email protected] ha scritto:
> > From: Matthias Brugger <[email protected]>
> >
> > The function svs_add_device_link is called only internally from the SoC
> > specific probe functions. We don't need to check if the node_name is
> > null because that would mean that we have a buggy SoC probe function in
> > the first place.
> >
> > Signed-off-by: Matthias Brugger <[email protected]>
>
> Reviewed-by: AngeloGioacchino Del Regno <
> [email protected]>

Reviewed-by: Roger Lu <[email protected]>

2023-02-14 13:56:02

by Matthias Brugger

Subject: Re: [PATCH] soc: mediatek: mtk-svs: delete node name check

On 11/02/2023 12:37, Roger Lu (陸瑞傑) wrote:
> On Fri, 2023-02-10 at 13:01 +0100, AngeloGioacchino Del Regno wrote:
>> Il 09/02/23 17:24, [email protected] ha scritto:
>>> From: Matthias Brugger <[email protected]>
>>>
>>> The function svs_add_device_link is called only internally from the SoC
>>> specific probe functions. We don't need to check if the node_name is
>>> null because that would mean that we have a buggy SoC probe function in
>>> the first place.
>>>
>>> Signed-off-by: Matthias Brugger <[email protected]>
>>
>> Reviewed-by: AngeloGioacchino Del Regno <
>> [email protected]>
>
> Reviewed-by: Roger Lu <[email protected]>

Applied, thanks for the reviews.
Matthias