From: Bartosz Golaszewski <[email protected]>
This series adds support for qcom-socinfo for SA8775P SoCs.
v1 -> v2:
- fix ordering of socinfo defines
- fix the commit subject line for patch 2/3
- collect the Ack from Krzysztof
Bartosz Golaszewski (3):
soc: qcom: smem: update max processor count
dt-bindings: arm: qcom: add the SoC ID for SA8775P
soc: qcom: socinfo: add support for SA8775P
drivers/soc/qcom/smem.c | 2 +-
drivers/soc/qcom/socinfo.c | 1 +
include/dt-bindings/arm/qcom,ids.h | 1 +
3 files changed, 3 insertions(+), 1 deletion(-)
--
2.37.2
From: Bartosz Golaszewski <[email protected]>
Update max processor count to reflect the number of co-processors on
SA8775P SoCs.
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/soc/qcom/smem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/qcom/smem.c b/drivers/soc/qcom/smem.c
index 4f163d62942c..7666b3425b7c 100644
--- a/drivers/soc/qcom/smem.c
+++ b/drivers/soc/qcom/smem.c
@@ -85,7 +85,7 @@
#define SMEM_GLOBAL_HOST 0xfffe
/* Max number of processors/hosts in a system */
-#define SMEM_HOST_COUNT 15
+#define SMEM_HOST_COUNT 20
/**
* struct smem_proc_comm - proc_comm communication struct (legacy)
--
2.37.2
From: Bartosz Golaszewski <[email protected]>
Add the SoC ID entry for SA8775P.
Signed-off-by: Bartosz Golaszewski <[email protected]>
Acked-by: Krzysztof Kozlowski <[email protected]>
---
include/dt-bindings/arm/qcom,ids.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/dt-bindings/arm/qcom,ids.h b/include/dt-bindings/arm/qcom,ids.h
index 22d7ba17804b..bfdf066cc690 100644
--- a/include/dt-bindings/arm/qcom,ids.h
+++ b/include/dt-bindings/arm/qcom,ids.h
@@ -223,6 +223,7 @@
#define QCOM_ID_SC7180P 495
#define QCOM_ID_SM6375 507
#define QCOM_ID_SM8550 519
+#define QCOM_ID_SA8775P 534
#define QCOM_ID_QRU1000 539
#define QCOM_ID_QDU1000 545
#define QCOM_ID_QDU1010 587
--
2.37.2
From: Bartosz Golaszewski <[email protected]>
Add SocInfo support for SA8775P.
Signed-off-by: Bartosz Golaszewski <[email protected]>
---
drivers/soc/qcom/socinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/soc/qcom/socinfo.c b/drivers/soc/qcom/socinfo.c
index e24895f98600..a951d0f7d3ba 100644
--- a/drivers/soc/qcom/socinfo.c
+++ b/drivers/soc/qcom/socinfo.c
@@ -436,6 +436,7 @@ static const struct soc_id soc_id[] = {
{ qcom_board_id(SC7180P) },
{ qcom_board_id(SM6375) },
{ qcom_board_id(SM8550) },
+ { qcom_board_id(SA8775P) },
{ qcom_board_id(QRU1000) },
{ qcom_board_id(QDU1000) },
{ qcom_board_id(QDU1010) },
--
2.37.2
On 09/02/2023 10:57, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Add SocInfo support for SA8775P.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/soc/qcom/socinfo.c | 1 +
Reviewed-by: Krzysztof Kozlowski <[email protected]>
Best regards,
Krzysztof
On Thu, Feb 09, 2023 at 10:57:51AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Update max processor count to reflect the number of co-processors on
> SA8775P SoCs.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/soc/qcom/smem.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Chanudet <[email protected]>
Tested-by: Eric Chanudet <[email protected]>
--
Eric Chanudet
On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Add the SoC ID entry for SA8775P.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> Acked-by: Krzysztof Kozlowski <[email protected]>
> ---
> include/dt-bindings/arm/qcom,ids.h | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Chanudet <[email protected]>
Tested-by: Eric Chanudet <[email protected]>
--
Eric Chanudet
On Thu, Feb 09, 2023 at 10:57:53AM +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> Add SocInfo support for SA8775P.
>
> Signed-off-by: Bartosz Golaszewski <[email protected]>
> ---
> drivers/soc/qcom/socinfo.c | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Chanudet <[email protected]>
Tested-by: Eric Chanudet <[email protected]> # sa8775p-ride
--
Eric Chanudet
On 09/02/2023 18:55, Eric Chanudet wrote:
> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
>> From: Bartosz Golaszewski <[email protected]>
>>
>> Add the SoC ID entry for SA8775P.
>>
>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>> Acked-by: Krzysztof Kozlowski <[email protected]>
>> ---
>> include/dt-bindings/arm/qcom,ids.h | 1 +
>> 1 file changed, 1 insertion(+)
>
> Reviewed-by: Eric Chanudet <[email protected]>
> Tested-by: Eric Chanudet <[email protected]>
How can you test a header? What type of testing Redhat does on the headers?
Best regards,
Krzysztof
On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote:
> On 09/02/2023 18:55, Eric Chanudet wrote:
> > On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
> >> From: Bartosz Golaszewski <[email protected]>
> >>
> >> Add the SoC ID entry for SA8775P.
> >>
> >> Signed-off-by: Bartosz Golaszewski <[email protected]>
> >> Acked-by: Krzysztof Kozlowski <[email protected]>
> >> ---
> >> include/dt-bindings/arm/qcom,ids.h | 1 +
> >> 1 file changed, 1 insertion(+)
> >
> > Reviewed-by: Eric Chanudet <[email protected]>
> > Tested-by: Eric Chanudet <[email protected]>
>
> How can you test a header? What type of testing Redhat does on the headers?
IIUC that ID is compared against the one read from SMEM by the socinfo
driver. I meant to confirm it matched the number the board I have
returned. My apologies in advance if that was inappropriate.
--
Eric Chanudet
On 10/02/2023 15:52, Eric Chanudet wrote:
> On Fri, Feb 10, 2023 at 09:58:29AM +0100, Krzysztof Kozlowski wrote:
>> On 09/02/2023 18:55, Eric Chanudet wrote:
>>> On Thu, Feb 09, 2023 at 10:57:52AM +0100, Bartosz Golaszewski wrote:
>>>> From: Bartosz Golaszewski <[email protected]>
>>>>
>>>> Add the SoC ID entry for SA8775P.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>>>> Acked-by: Krzysztof Kozlowski <[email protected]>
>>>> ---
>>>> include/dt-bindings/arm/qcom,ids.h | 1 +
>>>> 1 file changed, 1 insertion(+)
>>>
>>> Reviewed-by: Eric Chanudet <[email protected]>
>>> Tested-by: Eric Chanudet <[email protected]>
>>
>> How can you test a header? What type of testing Redhat does on the headers?
>
> IIUC that ID is compared against the one read from SMEM by the socinfo
> driver. I meant to confirm it matched the number the board I have
> returned. My apologies in advance if that was inappropriate.
OK... I would say it is a review then, but can be also this way.
Best regards,
Krzysztof
On Thu, Feb 9, 2023 at 10:57 AM Bartosz Golaszewski <[email protected]> wrote:
>
> From: Bartosz Golaszewski <[email protected]>
>
> This series adds support for qcom-socinfo for SA8775P SoCs.
>
> v1 -> v2:
> - fix ordering of socinfo defines
> - fix the commit subject line for patch 2/3
> - collect the Ack from Krzysztof
>
> Bartosz Golaszewski (3):
> soc: qcom: smem: update max processor count
> dt-bindings: arm: qcom: add the SoC ID for SA8775P
> soc: qcom: socinfo: add support for SA8775P
>
> drivers/soc/qcom/smem.c | 2 +-
> drivers/soc/qcom/socinfo.c | 1 +
> include/dt-bindings/arm/qcom,ids.h | 1 +
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
> --
> 2.37.2
>
Bjorn,
Looks like this is ready to go, so gentle ping.
Bart
On Thu, 9 Feb 2023 10:57:50 +0100, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <[email protected]>
>
> This series adds support for qcom-socinfo for SA8775P SoCs.
>
> v1 -> v2:
> - fix ordering of socinfo defines
> - fix the commit subject line for patch 2/3
> - collect the Ack from Krzysztof
>
> [...]
Applied, thanks!
[1/3] soc: qcom: smem: update max processor count
commit: b302c64a3c0a005f39155e9aef5e99ad8a9abbb7
[2/3] dt-bindings: arm: qcom: add the SoC ID for SA8775P
commit: 26a4bf805c6cd88847dd045f6b29d8a20f02d8df
[3/3] soc: qcom: socinfo: add support for SA8775P
commit: 7fa9c5fc1a753ac593904ebe9c4e8628a4240096
Best regards,
--
Bjorn Andersson <[email protected]>