2023-02-10 03:14:21

by Tinghan Shen

Subject: [PATCH v1] remoteproc: mediatek: Check the SCP image format

Do a sanity check on the SCP image before loading it to avoid
driver crashes.

Signed-off-by: Tinghan Shen <[email protected]>
---
drivers/remoteproc/mtk_scp.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
index d421a2ccaa1e..0861b76f185f 100644
--- a/drivers/remoteproc/mtk_scp.c
+++ b/drivers/remoteproc/mtk_scp.c
@@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
.load = scp_load,
.da_to_va = scp_da_to_va,
.parse_fw = scp_parse_fw,
+ .sanity_check = rproc_elf_sanity_check,
};

/**
--
2.18.0

2023-02-10 11:33:06

by Matthias Brugger

Subject: Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format

On 10/02/2023 04:13, Tinghan Shen wrote:
> Do a sanity check on the SCP image before loading it to avoid
> driver crashes.
>
> Signed-off-by: Tinghan Shen <[email protected]>

Reviewed-by: Matthias Brugger <[email protected]>

> ---
> drivers/remoteproc/mtk_scp.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index d421a2ccaa1e..0861b76f185f 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
> .load = scp_load,
> .da_to_va = scp_da_to_va,
> .parse_fw = scp_parse_fw,
> + .sanity_check = rproc_elf_sanity_check,
> };
>
> /**

2023-02-10 14:22:56

by AngeloGioacchino Del Regno

Subject: Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format

Il 10/02/23 12:32, Matthias Brugger ha scritto:
>
>
> On 10/02/2023 04:13, Tinghan Shen wrote:
>> Do a sanity check on the SCP image before loading it to avoid
>> driver crashes.
>>
>> Signed-off-by: Tinghan Shen <[email protected]>
>
> Reviewed-by: Matthias Brugger <[email protected]>

Reviewed-by: AngeloGioacchino Del Regno <[email protected]>

2023-02-12 20:24:13

by Mathieu Poirier

Subject: Re: [PATCH v1] remoteproc: mediatek: Check the SCP image format

On Fri, Feb 10, 2023 at 11:13:54AM +0800, Tinghan Shen wrote:
> Do a sanity check on the SCP image before loading it to avoid
> driver crashes.
>
> Signed-off-by: Tinghan Shen <[email protected]>
> ---
> drivers/remoteproc/mtk_scp.c | 1 +
> 1 file changed, 1 insertion(+)
>

I have applied this patch.

Thanks,
Mathieu

> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index d421a2ccaa1e..0861b76f185f 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -649,6 +649,7 @@ static const struct rproc_ops scp_ops = {
> .load = scp_load,
> .da_to_va = scp_da_to_va,
> .parse_fw = scp_parse_fw,
> + .sanity_check = rproc_elf_sanity_check,
> };
>
> /**
> --
> 2.18.0
>