2023-02-11 08:44:02

by Qing Zhang

Subject: [PATCH] selftests/ftrace: add LoongArch support for kprobe args string tests

before:
[5] Kprobe event string type argument [UNTESTED]
[7] Kprobe event argument syntax [UNTESTED]
after:
[5] Kprobe event string type argument [PASS]
[7] Kprobe event argument syntax [PASS]

Signed-off-by: Qing Zhang <[email protected]>
---
.../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
.../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
2 files changed, 7 insertions(+)

diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
index 459741565222..a4f8e7c53c1f 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
@@ -28,6 +28,9 @@ s390*)
mips*)
ARG1=%r4
;;
+loongarch*)
+ ARG1=%r4
+;;
*)
echo "Please implement other architecture here"
exit_untested
diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
index d4662c8cf407..1df61e13a812 100644
--- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
+++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
@@ -40,6 +40,10 @@ mips*)
GOODREG=%r4
BADREG=%r12
;;
+loongarch*)
+ GOODREG=%r4
+ BADREG=%r12
+;;
*)
echo "Please implement other architecture here"
exit_untested
--
2.36.0

2023-02-11 11:13:53

by Huacai Chen

Subject: Re: [PATCH] selftests/ftrace: add LoongArch support for kprobe args string tests

Queued, thanks.

Huacai

On Sat, Feb 11, 2023 at 4:43 PM Qing Zhang <[email protected]> wrote:
>
> before:
> [5] Kprobe event string type argument [UNTESTED]
> [7] Kprobe event argument syntax [UNTESTED]
> after:
> [5] Kprobe event string type argument [PASS]
> [7] Kprobe event argument syntax [PASS]
>
> Signed-off-by: Qing Zhang <[email protected]>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 459741565222..a4f8e7c53c1f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -28,6 +28,9 @@ s390*)
> mips*)
> ARG1=%r4
> ;;
> +loongarch*)
> + ARG1=%r4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index d4662c8cf407..1df61e13a812 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -40,6 +40,10 @@ mips*)
> GOODREG=%r4
> BADREG=%r12
> ;;
> +loongarch*)
> + GOODREG=%r4
> + BADREG=%r12
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> --
> 2.36.0
>
>

2023-02-12 23:29:28

by Masami Hiramatsu

Subject: Re: [PATCH] selftests/ftrace: add LoongArch support for kprobe args string tests

On Sat, 11 Feb 2023 16:43:46 +0800
Qing Zhang <[email protected]> wrote:

> before:
> [5] Kprobe event string type argument [UNTESTED]
> [7] Kprobe event argument syntax [UNTESTED]
> after:
> [5] Kprobe event string type argument [PASS]
> [7] Kprobe event argument syntax [PASS]
>

Thanks for updating the test!

Reviewed-by: Masami Hiramatsu (Google) <[email protected]>

> Signed-off-by: Qing Zhang <[email protected]>
> ---
> .../selftests/ftrace/test.d/kprobe/kprobe_args_string.tc | 3 +++
> .../selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc | 4 ++++
> 2 files changed, 7 insertions(+)
>
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> index 459741565222..a4f8e7c53c1f 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_string.tc
> @@ -28,6 +28,9 @@ s390*)
> mips*)
> ARG1=%r4
> ;;
> +loongarch*)
> + ARG1=%r4
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> diff --git a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> index d4662c8cf407..1df61e13a812 100644
> --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_args_syntax.tc
> @@ -40,6 +40,10 @@ mips*)
> GOODREG=%r4
> BADREG=%r12
> ;;
> +loongarch*)
> + GOODREG=%r4
> + BADREG=%r12
> +;;
> *)
> echo "Please implement other architecture here"
> exit_untested
> --
> 2.36.0
>


--
Masami Hiramatsu (Google) <[email protected]>