2023-02-11 15:29:51

by Tom Rix

Subject: [PATCH] staging: rtl8192e: set dm_rx_path_sel_table storage-class-specifier to static

smatch reports
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c:147:21:
warning: symbol 'dm_rx_path_sel_table' was not declared. Should it be static?

dm_rx_path_sel_table is only used in rtl_dm.c, so it should be static

Signed-off-by: Tom Rix <[email protected]>
---
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
index d8455b23e555..3bc5dabf2e2c 100644
--- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
+++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
@@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
/*------------------------Define global variable-----------------------------*/
struct dig_t dm_digtable;

-struct drx_path_sel dm_rx_path_sel_table;
+static struct drx_path_sel dm_rx_path_sel_table;
/*------------------------Define global variable-----------------------------*/


--
2.26.3

2023-02-11 16:40:32

by Greg Kroah-Hartman

Subject: Re: [PATCH] staging: rtl8192e: set dm_rx_path_sel_table storage-class-specifier to static

On Sat, Feb 11, 2023 at 07:28:56AM -0800, Tom Rix wrote:
> smatch reports
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c:147:21:
> warning: symbol 'dm_rx_path_sel_table' was not declared. Should it be static?
>
> dm_rx_path_sel_table is only used in rtl_dm.c, so it should be static
>
> Signed-off-by: Tom Rix <[email protected]>
> ---
> drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> index d8455b23e555..3bc5dabf2e2c 100644
> --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c
> @@ -144,7 +144,7 @@ const u8 dm_cck_tx_bb_gain_ch14[CCK_TX_BB_GAIN_TABLE_LEN][8] = {
> /*------------------------Define global variable-----------------------------*/
> struct dig_t dm_digtable;
>
> -struct drx_path_sel dm_rx_path_sel_table;
> +static struct drx_path_sel dm_rx_path_sel_table;

So now you have a local variable in the chunk that says "global
variable" :(

Please always be aware of the context of the code you are changing.

thanks,

greg k-h