Addition of the various STi platform syscon node description.
Signed-off-by: Alain Volmat <[email protected]>
---
.../bindings/arm/sti/st,sti-syscon.yaml | 46 +++++++++++++++++++
1 file changed, 46 insertions(+)
create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
diff --git a/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
new file mode 100644
index 000000000000..e4bbc90694b3
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
@@ -0,0 +1,46 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: STMicroelectronics STi platform sysconfig entries
+
+maintainers:
+ - Patrice Chotard <[email protected]>
+
+description: |
+ Binding for the various sysconfig nodes used within the STi
+ platform device-tree to point to some common configuration
+ registers used by other nodes.
+
+properties:
+ compatible:
+ items:
+ - enum:
+ - st,stih407-sbc-syscfg
+ - st,stih407-front-syscfg
+ - st,stih407-rear-syscfg
+ - st,stih407-flash-syscfg
+ - st,stih407-sbc-reg-syscfg
+ - st,stih407-core-syscfg
+ - st,stih407-lpm-syscfg
+ - const: syscon
+
+ reg:
+ maxItems: 1
+
+required:
+ - compatible
+ - reg
+
+additionalProperties: false
+
+examples:
+ - |
+ syscfg_sbc: sbc-syscfg@9620000 {
+ compatible = "st,stih407-sbc-syscfg", "syscon";
+ reg = <0x9620000 0x1000>;
+ };
+
+...
--
2.34.1
Add bindings for STi platform boards and remove stih415/stih416 items.
This commit also moves the sti.yaml binding file within the arm/sti/
folder instead of arm/
Signed-off-by: Alain Volmat <[email protected]>
---
.../devicetree/bindings/arm/sti.yaml | 26 ---------------
.../devicetree/bindings/arm/sti/sti.yaml | 33 +++++++++++++++++++
2 files changed, 33 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
deleted file mode 100644
index 3ca054c64377..000000000000
--- a/Documentation/devicetree/bindings/arm/sti.yaml
+++ /dev/null
@@ -1,26 +0,0 @@
-# SPDX-License-Identifier: GPL-2.0
-%YAML 1.2
----
-$id: http://devicetree.org/schemas/arm/sti.yaml#
-$schema: http://devicetree.org/meta-schemas/core.yaml#
-
-title: ST STi Platforms
-
-maintainers:
- - Patrice Chotard <[email protected]>
-
-properties:
- $nodename:
- const: '/'
- compatible:
- items:
- - enum:
- - st,stih415
- - st,stih416
- - st,stih407
- - st,stih410
- - st,stih418
-
-additionalProperties: true
-
-...
diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
new file mode 100644
index 000000000000..aefa1919207c
--- /dev/null
+++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
@@ -0,0 +1,33 @@
+# SPDX-License-Identifier: GPL-2.0
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/arm/sti/sti.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: ST STi Platforms
+
+maintainers:
+ - Patrice Chotard <[email protected]>
+
+properties:
+ $nodename:
+ const: '/'
+ compatible:
+ oneOf:
+ - items:
+ - const: st,stih407-b2120
+ - const: st,stih407
+ - items:
+ - enum:
+ - st,stih410-b2120
+ - st,stih410-b2260
+ - const: st,stih410
+ - items:
+ - enum:
+ - st,stih418-b2199
+ - st,stih418-b2264
+ - const: st,stih418
+
+additionalProperties: true
+
+...
--
2.34.1
Thank you for your patch. There is something to discuss/improve. Few nits.
On 11/02/2023 22:04, Alain Volmat wrote:
> Addition of the various STi platform syscon node description.
Use imperative.
https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> .../bindings/arm/sti/st,sti-syscon.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> new file mode 100644
> index 000000000000..e4bbc90694b3
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> @@ -0,0 +1,46 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: STMicroelectronics STi platform sysconfig entries
Drop "entries", does not look related to hardware.
> +
> +maintainers:
> + - Patrice Chotard <[email protected]>
> +
> +description: |
> + Binding for the various sysconfig nodes used within the STi
> + platform device-tree to point to some common configuration
> + registers used by other nodes.
> +
> +properties:
> + compatible:
> + items:
> + - enum:
> + - st,stih407-sbc-syscfg
> + - st,stih407-front-syscfg
> + - st,stih407-rear-syscfg
> + - st,stih407-flash-syscfg
> + - st,stih407-sbc-reg-syscfg
> + - st,stih407-core-syscfg
> + - st,stih407-lpm-syscfg
How about putting them in some order?
> + - const: syscon
> +
> + reg:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + syscfg_sbc: sbc-syscfg@9620000 {
Generic node names, thus usually syscon or system-controller
> +...
Best regards,
Krzysztof
On 11/02/2023 22:04, Alain Volmat wrote:
> Addition of the various STi platform syscon node description.
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> .../bindings/arm/sti/st,sti-syscon.yaml | 46 +++++++++++++++++++
> 1 file changed, 46 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
Ah, and one more - incorrect directory. This should be in soc, not arm.
Best regards,
Krzysztof
On 11/02/2023 22:04, Alain Volmat wrote:
> Add bindings for STi platform boards and remove stih415/stih416 items.
> This commit also moves the sti.yaml binding file within the arm/sti/
> folder instead of arm/
>
> Signed-off-by: Alain Volmat <[email protected]>
> ---
> .../devicetree/bindings/arm/sti.yaml | 26 ---------------
> .../devicetree/bindings/arm/sti/sti.yaml | 33 +++++++++++++++++++
> 2 files changed, 33 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
> create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
> deleted file mode 100644
> index 3ca054c64377..000000000000
> --- a/Documentation/devicetree/bindings/arm/sti.yaml
> +++ /dev/null
> @@ -1,26 +0,0 @@
> -# SPDX-License-Identifier: GPL-2.0
> -%YAML 1.2
> ----
> -$id: http://devicetree.org/schemas/arm/sti.yaml#
> -$schema: http://devicetree.org/meta-schemas/core.yaml#
> -
> -title: ST STi Platforms
> -
> -maintainers:
> - - Patrice Chotard <[email protected]>
> -
> -properties:
> - $nodename:
> - const: '/'
> - compatible:
> - items:
> - - enum:
> - - st,stih415
> - - st,stih416
> - - st,stih407
> - - st,stih410
> - - st,stih418
> -
> -additionalProperties: true
> -
> -...
> diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> new file mode 100644
> index 000000000000..aefa1919207c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> @@ -0,0 +1,33 @@
> +# SPDX-License-Identifier: GPL-2.0
Dual-license. I don't think there is anything from old binding being
copied here (you can as well start from scratch from other binding and
result will be the same).
Best regards,
Krzysztof
Thanks for the review.
On Sun, Feb 12, 2023 at 05:00:24PM +0100, Krzysztof Kozlowski wrote:
> Thank you for your patch. There is something to discuss/improve. Few nits.
>
> On 11/02/2023 22:04, Alain Volmat wrote:
> > Addition of the various STi platform syscon node description.
>
> Use imperative.
> https://elixir.bootlin.com/linux/v5.17.1/source/Documentation/process/submitting-patches.rst#L95
>
> >
> > Signed-off-by: Alain Volmat <[email protected]>
> > ---
> > .../bindings/arm/sti/st,sti-syscon.yaml | 46 +++++++++++++++++++
> > 1 file changed, 46 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> > new file mode 100644
> > index 000000000000..e4bbc90694b3
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/sti/st,sti-syscon.yaml
> > @@ -0,0 +1,46 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/arm/sti/st,sti-syscon.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: STMicroelectronics STi platform sysconfig entries
>
>
> Drop "entries", does not look related to hardware.
>
> > +
> > +maintainers:
> > + - Patrice Chotard <[email protected]>
> > +
> > +description: |
> > + Binding for the various sysconfig nodes used within the STi
> > + platform device-tree to point to some common configuration
> > + registers used by other nodes.
> > +
> > +properties:
> > + compatible:
> > + items:
> > + - enum:
> > + - st,stih407-sbc-syscfg
> > + - st,stih407-front-syscfg
> > + - st,stih407-rear-syscfg
> > + - st,stih407-flash-syscfg
> > + - st,stih407-sbc-reg-syscfg
> > + - st,stih407-core-syscfg
> > + - st,stih407-lpm-syscfg
>
> How about putting them in some order?
Ok, changed to alphabet order
>
> > + - const: syscon
> > +
> > + reg:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > + syscfg_sbc: sbc-syscfg@9620000 {
>
> Generic node names, thus usually syscon or system-controller
Ok, changed to syscfg_sbc: syscon@9620000
I also move the file within bindings/soc/sti as mentioned in your other
reply.
> > +...
>
> Best regards,
> Krzysztof
>
Thanks for the review
On Sun, Feb 12, 2023 at 05:02:17PM +0100, Krzysztof Kozlowski wrote:
> On 11/02/2023 22:04, Alain Volmat wrote:
> > Add bindings for STi platform boards and remove stih415/stih416 items.
> > This commit also moves the sti.yaml binding file within the arm/sti/
> > folder instead of arm/
> >
> > Signed-off-by: Alain Volmat <[email protected]>
> > ---
> > .../devicetree/bindings/arm/sti.yaml | 26 ---------------
> > .../devicetree/bindings/arm/sti/sti.yaml | 33 +++++++++++++++++++
> > 2 files changed, 33 insertions(+), 26 deletions(-)
> > delete mode 100644 Documentation/devicetree/bindings/arm/sti.yaml
> > create mode 100644 Documentation/devicetree/bindings/arm/sti/sti.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/arm/sti.yaml b/Documentation/devicetree/bindings/arm/sti.yaml
> > deleted file mode 100644
> > index 3ca054c64377..000000000000
> > --- a/Documentation/devicetree/bindings/arm/sti.yaml
> > +++ /dev/null
> > @@ -1,26 +0,0 @@
> > -# SPDX-License-Identifier: GPL-2.0
> > -%YAML 1.2
> > ----
> > -$id: http://devicetree.org/schemas/arm/sti.yaml#
> > -$schema: http://devicetree.org/meta-schemas/core.yaml#
> > -
> > -title: ST STi Platforms
> > -
> > -maintainers:
> > - - Patrice Chotard <[email protected]>
> > -
> > -properties:
> > - $nodename:
> > - const: '/'
> > - compatible:
> > - items:
> > - - enum:
> > - - st,stih415
> > - - st,stih416
> > - - st,stih407
> > - - st,stih410
> > - - st,stih418
> > -
> > -additionalProperties: true
> > -
> > -...
> > diff --git a/Documentation/devicetree/bindings/arm/sti/sti.yaml b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > new file mode 100644
> > index 000000000000..aefa1919207c
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/arm/sti/sti.yaml
> > @@ -0,0 +1,33 @@
> > +# SPDX-License-Identifier: GPL-2.0
>
> Dual-license. I don't think there is anything from old binding being
> copied here (you can as well start from scratch from other binding and
> result will be the same).
Ok
I understand, based on your review of the other patch in the serie that
I should put this sti.yaml within bindings/soc/sti right ?
Moreover, I made a mistake and removed st,stih415 and st,stih416 in
this patch while I already posted the patch in the STiH415/STiH416
removal serie (https://lore.kernel.org/all/[email protected]/).
I propose to get rid of the patch in the other serie and do the removal
within this patch since it also moves the file.
>
> Best regards,
> Krzysztof
>