2023-02-13 01:05:55

by Yang Li

Subject: [PATCH -next] ASoC: codecs: Remove unneeded semicolon

./sound/soc/codecs/peb2466.c:1851:2-3: Unneeded semicolon
./sound/soc/codecs/peb2466.c:1887:2-3: Unneeded semicolon

Reported-by: Abaci Robot <[email protected]>
Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4045
Signed-off-by: Yang Li <[email protected]>
---
sound/soc/codecs/peb2466.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/sound/soc/codecs/peb2466.c b/sound/soc/codecs/peb2466.c
index 4640b1860312..5dec69be0acb 100644
--- a/sound/soc/codecs/peb2466.c
+++ b/sound/soc/codecs/peb2466.c
@@ -1848,7 +1848,7 @@ static int peb2466_chip_direction_input(struct gpio_chip *c, unsigned int offset
if (offset < 16) {
/* SOx_{0,1} */
return -EINVAL;
- };
+ }

ret = peb2466_chip_gpio_offset_to_dir_regmask(offset, &xr_reg, &mask);
if (ret) {
@@ -1884,7 +1884,7 @@ static int peb2466_chip_direction_output(struct gpio_chip *c, unsigned int offse
if (offset < 16) {
/* SOx_{0,1} */
return 0;
- };
+ }

ret = peb2466_chip_gpio_offset_to_dir_regmask(offset, &xr_reg, &mask);
if (ret) {
--
2.20.1.7.g153144c

2023-02-13 06:58:20

by Herve Codina

Subject: Re: [PATCH -next] ASoC: codecs: Remove unneeded semicolon

Hi Yang,

On Mon, 13 Feb 2023 09:05:47 +0800
Yang Li <[email protected]> wrote:

> ./sound/soc/codecs/peb2466.c:1851:2-3: Unneeded semicolon
> ./sound/soc/codecs/peb2466.c:1887:2-3: Unneeded semicolon
>
> Reported-by: Abaci Robot <[email protected]>
> Link: https://bugzilla.openanolis.cn/show_bug.cgi?id=4045
> Signed-off-by: Yang Li <[email protected]>
> ---
> sound/soc/codecs/peb2466.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>

Oups, I missed those. My bad.

Acked-by: Herve Codina <[email protected]>

Thanks,
Hervé

--
Hervé Codina, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

2023-02-13 16:19:02

by Mark Brown

Subject: Re: [PATCH -next] ASoC: codecs: Remove unneeded semicolon

On Mon, 13 Feb 2023 09:05:47 +0800, Yang Li wrote:
> ./sound/soc/codecs/peb2466.c:1851:2-3: Unneeded semicolon
> ./sound/soc/codecs/peb2466.c:1887:2-3: Unneeded semicolon
>
>

Applied to

broonie/sound.git for-next

Thanks!

[1/1] ASoC: codecs: Remove unneeded semicolon
commit: d227116c0e216da2eceba1d51a364ff025dffa58

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark