2023-02-14 03:26:00

by Thomas Weißschuh

Subject: [PATCH] iommu: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/iommu/iommu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c
index 5f6a85aea501..1dd4ec31301d 100644
--- a/drivers/iommu/iommu.c
+++ b/drivers/iommu/iommu.c
@@ -714,7 +714,7 @@ static void iommu_group_release(struct kobject *kobj)
kfree(group);
}

-static struct kobj_type iommu_group_ktype = {
+static const struct kobj_type iommu_group_ktype = {
.sysfs_ops = &iommu_group_sysfs_ops,
.release = iommu_group_release,
};

---
base-commit: f6feea56f66d34259c4222fa02e8171c4f2673d1
change-id: 20230214-kobj_type-iommu-9eede43d1075

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-03-22 13:31:38

by Joerg Roedel

Subject: Re: [PATCH] iommu: make kobj_type structure constant

On Tue, Feb 14, 2023 at 03:25:53AM +0000, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---

Applied, thanks.

Btw, b4 reported DKIM errors checking your patch submission. Can you
check the DKIM setup on you email domain, please?

2023-03-22 22:27:31

by Thomas Weißschuh

Subject: Re: [PATCH] iommu: make kobj_type structure constant

Hi Joerg,


Mar 22, 2023 08:20:14 Joerg Roedel <[email protected]>:

> On Tue, Feb 14, 2023 at 03:25:53AM +0000, Thomas Weißschuh wrote:
>> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
>> the driver core allows the usage of const struct kobj_type.
>>
>> Take advantage of this to constify the structure definition to prevent
>> modification at runtime.
>>
>> Signed-off-by: Thomas Weißschuh <[email protected]>
>> ---
>
> Applied, thanks.

Thanks!

> Btw, b4 reported DKIM errors checking your patch submission. Can you
> check the DKIM setup on you email domain, please?

Should be fixed for some time.
(After this patch, though)

Thanks for the hint!

Thomas