2023-02-14 10:39:56

by Sergio Paracuellos

Subject: [PATCH v7 3/5] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog

To allow to access system controller registers from watchdog driver code
add a phandle in the watchdog 'wdt' node. This avoid using arch dependent
operations in driver code.

Reviewed-by: Arınç ÜNAL <[email protected]>
Signed-off-by: Sergio Paracuellos <[email protected]>
---
arch/mips/boot/dts/ralink/mt7621.dtsi | 1 +
1 file changed, 1 insertion(+)

diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
index ac818fd721ae..3d16beb77440 100644
--- a/arch/mips/boot/dts/ralink/mt7621.dtsi
+++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
@@ -73,6 +73,7 @@ sysc: syscon@0 {
wdt: watchdog@100 {
compatible = "mediatek,mt7621-wdt";
reg = <0x100 0x100>;
+ mediatek,sysctl = <&sysc>;
};

gpio: gpio@600 {
--
2.25.1

2023-02-14 15:11:26

by Guenter Roeck

Subject: Re: [PATCH v7 3/5] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog

On Tue, Feb 14, 2023 at 11:39:34AM +0100, Sergio Paracuellos wrote:
> To allow to access system controller registers from watchdog driver code
> add a phandle in the watchdog 'wdt' node. This avoid using arch dependent
> operations in driver code.
>
> Reviewed-by: Arınç ÜNAL <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>

Acked-by: Guenter Roeck <[email protected]>

> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index ac818fd721ae..3d16beb77440 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -73,6 +73,7 @@ sysc: syscon@0 {
> wdt: watchdog@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> + mediatek,sysctl = <&sysc>;
> };
>
> gpio: gpio@600 {
> --
> 2.25.1
>

2023-02-28 22:19:20

by Thomas Bogendoerfer

Subject: Re: [PATCH v7 3/5] mips: dts: ralink: mt7621: add phandle to system controller node for watchdog

On Tue, Feb 14, 2023 at 11:39:34AM +0100, Sergio Paracuellos wrote:
> To allow to access system controller registers from watchdog driver code
> add a phandle in the watchdog 'wdt' node. This avoid using arch dependent
> operations in driver code.
>
> Reviewed-by: Arınç ÜNAL <[email protected]>
> Signed-off-by: Sergio Paracuellos <[email protected]>
> ---
> arch/mips/boot/dts/ralink/mt7621.dtsi | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/mips/boot/dts/ralink/mt7621.dtsi b/arch/mips/boot/dts/ralink/mt7621.dtsi
> index ac818fd721ae..3d16beb77440 100644
> --- a/arch/mips/boot/dts/ralink/mt7621.dtsi
> +++ b/arch/mips/boot/dts/ralink/mt7621.dtsi
> @@ -73,6 +73,7 @@ sysc: syscon@0 {
> wdt: watchdog@100 {
> compatible = "mediatek,mt7621-wdt";
> reg = <0x100 0x100>;
> + mediatek,sysctl = <&sysc>;
> };
>
> gpio: gpio@600 {
> --
> 2.25.1

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]