2023-02-15 01:03:54

by Thomas Weißschuh

Subject: [PATCH 0/4] HID: explicitly include linux/leds.h

Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
Thomas Weißschuh (4):
HID: steelseries: explicitly include linux/leds.h
HID: lg-g15: explicitly include linux/leds.h
HID: asus: explicitly include linux/leds.h
HID: apple: explicitly include linux/leds.h

drivers/hid/hid-apple.c | 1 +
drivers/hid/hid-asus.c | 1 +
drivers/hid/hid-lg-g15.c | 1 +
drivers/hid/hid-steelseries.c | 1 +
4 files changed, 4 insertions(+)
---
base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-15 01:03:57

by Thomas Weißschuh

Subject: [PATCH 1/4] HID: steelseries: explicitly include linux/leds.h

Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/hid/hid-steelseries.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-steelseries.c b/drivers/hid/hid-steelseries.c
index 37353c41cba7..aae3afc4107a 100644
--- a/drivers/hid/hid-steelseries.c
+++ b/drivers/hid/hid-steelseries.c
@@ -11,6 +11,7 @@
#include <linux/device.h>
#include <linux/hid.h>
#include <linux/module.h>
+#include <linux/leds.h>

#include "hid-ids.h"


--
2.39.2

2023-02-15 01:04:00

by Thomas Weißschuh

Subject: [PATCH 4/4] HID: apple: explicitly include linux/leds.h

Instead of relying on an accidental, transitive inclusion of linux/leds.h
use it directly.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/hid/hid-apple.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/drivers/hid/hid-apple.c b/drivers/hid/hid-apple.c
index 1ccab8aa326c..c5b45cd1e44d 100644
--- a/drivers/hid/hid-apple.c
+++ b/drivers/hid/hid-apple.c
@@ -22,6 +22,7 @@
#include <linux/slab.h>
#include <linux/timer.h>
#include <linux/string.h>
+#include <linux/leds.h>

#include "hid-ids.h"


--
2.39.2

2023-03-20 22:21:00

by Thomas Weißschuh

Subject: Re: [PATCH 0/4] HID: explicitly include linux/leds.h

Friendly ping,

this seems to have fallen through the cracks.

Thanks,
Thomas

On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>
> ---
> Thomas Weißschuh (4):
> HID: steelseries: explicitly include linux/leds.h
> HID: lg-g15: explicitly include linux/leds.h
> HID: asus: explicitly include linux/leds.h
> HID: apple: explicitly include linux/leds.h
>
> drivers/hid/hid-apple.c | 1 +
> drivers/hid/hid-asus.c | 1 +
> drivers/hid/hid-lg-g15.c | 1 +
> drivers/hid/hid-steelseries.c | 1 +
> 4 files changed, 4 insertions(+)
> ---
> base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
>
> Best regards,
> --
> Thomas Weißschuh <[email protected]>
>

2023-04-13 15:11:32

by Benjamin Tissoires

Subject: Re: (subset) [PATCH 0/4] HID: explicitly include linux/leds.h

On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
>

Applied to hid/hid.git (for-6.4/apple), thanks!

[4/4] HID: apple: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/6c89c1160321

Cheers,
--
Benjamin Tissoires <[email protected]>

2023-04-13 15:13:22

by Benjamin Tissoires

Subject: Re: (subset) [PATCH 0/4] HID: explicitly include linux/leds.h

On Wed, 15 Feb 2023 01:03:33 +0000, Thomas Weißschuh wrote:
> Instead of relying on an accidental, transitive inclusion of linux/leds.h
> use it directly.
>
>

Applied to https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git (for-6.4/led-includes), thanks!

[1/4] HID: steelseries: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/f28bb5ce4f15
[2/4] HID: lg-g15: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/21c5bd5b4b06
[3/4] HID: asus: explicitly include linux/leds.h
https://git.kernel.org/hid/hid/c/a2654c1f640c

Cheers,
--
Benjamin Tissoires <[email protected]>

2023-04-13 15:14:44

by Benjamin Tissoires

Subject: Re: [PATCH 0/4] HID: explicitly include linux/leds.h

On Mar 20 2023, Thomas Wei?schuh wrote:
> Friendly ping,
>
> this seems to have fallen through the cracks.

Sorry for the delay.

I have applied them now, as should have told you the automatic
notifications.

Cheers,
Benjamin

>
> Thanks,
> Thomas
>
> On Wed, Feb 15, 2023 at 01:03:33AM +0000, Thomas Wei?schuh wrote:
> > Instead of relying on an accidental, transitive inclusion of linux/leds.h
> > use it directly.
> >
> > Signed-off-by: Thomas Wei?schuh <[email protected]>
> > ---
> > Thomas Wei?schuh (4):
> > HID: steelseries: explicitly include linux/leds.h
> > HID: lg-g15: explicitly include linux/leds.h
> > HID: asus: explicitly include linux/leds.h
> > HID: apple: explicitly include linux/leds.h
> >
> > drivers/hid/hid-apple.c | 1 +
> > drivers/hid/hid-asus.c | 1 +
> > drivers/hid/hid-lg-g15.c | 1 +
> > drivers/hid/hid-steelseries.c | 1 +
> > 4 files changed, 4 insertions(+)
> > ---
> > base-commit: e1c04510f521e853019afeca2a5991a5ef8d6a5b
> > change-id: 20230215-power_supply-leds-hid-f99a0a3fd2bf
> >
> > Best regards,
> > --
> > Thomas Wei?schuh <[email protected]>
> >