2023-02-15 02:14:35

by Guru Das Srinagesh

Subject: [PATCH 1/1] lib/bitmap: Export __bitmap_or_equal

Commit b9fa6442f704 ("cpumask: Implement cpumask_or_equal()") missed out on
exporting __bitmap_or_equal() while introducing it. Fix this.

Signed-off-by: Guru Das Srinagesh <[email protected]>
---
lib/bitmap.c | 1 +
1 file changed, 1 insertion(+)

diff --git a/lib/bitmap.c b/lib/bitmap.c
index 1c81413c51f8..316079e39431 100644
--- a/lib/bitmap.c
+++ b/lib/bitmap.c
@@ -80,6 +80,7 @@ bool __bitmap_or_equal(const unsigned long *bitmap1,
tmp = (bitmap1[k] | bitmap2[k]) ^ bitmap3[k];
return (tmp & BITMAP_LAST_WORD_MASK(bits)) == 0;
}
+EXPORT_SYMBOL(__bitmap_or_equal);

void __bitmap_complement(unsigned long *dst, const unsigned long *src, unsigned int bits)
{
--
2.39.1

2023-02-15 07:56:30

by Christoph Hellwig

Subject: Re: [PATCH 1/1] lib/bitmap: Export __bitmap_or_equal

On Tue, Feb 14, 2023 at 06:14:07PM -0800, Guru Das Srinagesh wrote:
> Commit b9fa6442f704 ("cpumask: Implement cpumask_or_equal()") missed out on
> exporting __bitmap_or_equal() while introducing it. Fix this.

What code fails to build without it?

Right now it only appears to be used by the x86 APIC code through
cpumask_or_equal, which must be built in.