2023-02-15 05:05:19

by Oleksij Rempel

Subject: [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error

Fix warning:
drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'

Reported-by: kernel test robot <[email protected]>
Reported-by: Dan Carpenter <[email protected]>
Link: https://lore.kernel.org/r/[email protected]/
Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
Signed-off-by: Oleksij Rempel <[email protected]>
---
drivers/net/phy/phy-c45.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/phy/phy-c45.c b/drivers/net/phy/phy-c45.c
index ef36582adbeb..f9b128cecc3f 100644
--- a/drivers/net/phy/phy-c45.c
+++ b/drivers/net/phy/phy-c45.c
@@ -256,7 +256,7 @@ static int genphy_c45_baset1_an_config_aneg(struct phy_device *phydev)
*/
int genphy_c45_an_config_aneg(struct phy_device *phydev)
{
- int changed, ret;
+ int changed = 0, ret;
u32 adv;

linkmode_and(phydev->advertising, phydev->advertising,
--
2.30.2

2023-02-15 17:45:40

by Andrew Lunn

Subject: Re: [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error

On Wed, Feb 15, 2023 at 06:04:53AM +0100, Oleksij Rempel wrote:
> Fix warning:
> drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]/
> Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
> Signed-off-by: Oleksij Rempel <[email protected]>

Reviewed-by: Andrew Lunn <[email protected]>

Andrew

2023-02-16 05:30:27

by patchwork-bot+netdevbpf

Subject: Re: [PATCH net-next v1 1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error

Hello:

This patch was applied to netdev/net-next.git (master)
by Jakub Kicinski <[email protected]>:

On Wed, 15 Feb 2023 06:04:53 +0100 you wrote:
> Fix warning:
> drivers/net/phy/phy-c45.c:712 genphy_c45_write_eee_adv() error: uninitialized symbol 'changed'
>
> Reported-by: kernel test robot <[email protected]>
> Reported-by: Dan Carpenter <[email protected]>
> Link: https://lore.kernel.org/r/[email protected]/
> Fixes: 022c3f87f88e ("net: phy: add genphy_c45_ethtool_get/set_eee() support")
> Signed-off-by: Oleksij Rempel <[email protected]>
>
> [...]

Here is the summary with links:
- [net-next,v1,1/1] net: phy: c45: genphy_c45_an_config_aneg(): fix uninitialized symbol error
https://git.kernel.org/netdev/net-next/c/c24a34f5a3d7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html