2023-02-15 06:49:40

by ye.xingchen

Subject: [PATCH] power: reset: at91-poweroff: Use devm_platform_get_and_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to devm_platform_get_and_ioremap_resource(), as this is exactly
what this function does.

Signed-off-by: Ye Xingchen <[email protected]>
---
drivers/power/reset/at91-poweroff.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
index 9e74e131c675..b7e17afe30e2 100644
--- a/drivers/power/reset/at91-poweroff.c
+++ b/drivers/power/reset/at91-poweroff.c
@@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)

static int __init at91_poweroff_probe(struct platform_device *pdev)
{
- struct resource *res;
struct device_node *np;
u32 ddr_type;
int ret;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
+ at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
if (IS_ERR(at91_shdwc.shdwc_base))
return PTR_ERR(at91_shdwc.shdwc_base);

--
2.25.1

2023-02-16 10:01:36

by Claudiu Beznea

Subject: Re: [PATCH] power: reset: at91-poweroff: Use  devm_platform_get_and_ioremap_resource()

On 15.02.2023 08:49, [email protected] wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
>
> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to devm_platform_get_and_ioremap_resource(), as this is exactly
> what this function does.
>
> Signed-off-by: Ye Xingchen <[email protected]>

Reviewed-by: Claudiu Beznea <[email protected]>


> ---
> drivers/power/reset/at91-poweroff.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/power/reset/at91-poweroff.c b/drivers/power/reset/at91-poweroff.c
> index 9e74e131c675..b7e17afe30e2 100644
> --- a/drivers/power/reset/at91-poweroff.c
> +++ b/drivers/power/reset/at91-poweroff.c
> @@ -151,13 +151,11 @@ static void at91_poweroff_dt_set_wakeup_mode(struct platform_device *pdev)
>
> static int __init at91_poweroff_probe(struct platform_device *pdev)
> {
> - struct resource *res;
> struct device_node *np;
> u32 ddr_type;
> int ret;
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - at91_shdwc.shdwc_base = devm_ioremap_resource(&pdev->dev, res);
> + at91_shdwc.shdwc_base = devm_platform_get_and_ioremap_resource(pdev, 0, NULL);
> if (IS_ERR(at91_shdwc.shdwc_base))
> return PTR_ERR(at91_shdwc.shdwc_base);
>
> --
> 2.25.1