2023-02-16 01:12:32

by Thomas Weißschuh

Subject: [PATCH] PCI/sysfs: Make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
drivers/pci/slot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
index a0c67191a8b9..0f87cade10f7 100644
--- a/drivers/pci/slot.c
+++ b/drivers/pci/slot.c
@@ -98,7 +98,7 @@ static struct attribute *pci_slot_default_attrs[] = {
};
ATTRIBUTE_GROUPS(pci_slot_default);

-static struct kobj_type pci_slot_ktype = {
+static const struct kobj_type pci_slot_ktype = {
.sysfs_ops = &pci_slot_sysfs_ops,
.release = &pci_slot_release,
.default_groups = pci_slot_default_groups,

---
base-commit: 033c40a89f55525139fd5b6342281b09b97d05bf
change-id: 20230216-kobj_type-pci-56120c1c0bcb

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-16 18:02:04

by Bjorn Helgaas

Subject: Re: [PATCH] PCI/sysfs: Make kobj_type structure constant

On Thu, Feb 16, 2023 at 01:12:25AM +0000, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>

Applied to pci/misc for v6.13, thanks, Thomas!

> ---
> drivers/pci/slot.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/slot.c b/drivers/pci/slot.c
> index a0c67191a8b9..0f87cade10f7 100644
> --- a/drivers/pci/slot.c
> +++ b/drivers/pci/slot.c
> @@ -98,7 +98,7 @@ static struct attribute *pci_slot_default_attrs[] = {
> };
> ATTRIBUTE_GROUPS(pci_slot_default);
>
> -static struct kobj_type pci_slot_ktype = {
> +static const struct kobj_type pci_slot_ktype = {
> .sysfs_ops = &pci_slot_sysfs_ops,
> .release = &pci_slot_release,
> .default_groups = pci_slot_default_groups,
>
> ---
> base-commit: 033c40a89f55525139fd5b6342281b09b97d05bf
> change-id: 20230216-kobj_type-pci-56120c1c0bcb
>
> Best regards,
> --
> Thomas Wei?schuh <[email protected]>
>