2023-02-16 02:55:12

by ye.xingchen

Subject: [PATCH v2] reset: meson: Use devm_platform_ioremap_resource()

From: Ye Xingchen <[email protected]>

Convert platform_get_resource(), devm_ioremap_resource() to a single
call to Use devm_platform_ioremap_resource(), as this is exactly
what this function does.

Suggested-by: Philipp Zabel <[email protected]>
Signed-off-by: Ye Xingchen <[email protected]>
---
v1 -> v2
change devm_platform_get_and_ioremap_resource() to
devm_platform_ioremap_resource().
drivers/reset/reset-meson.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/reset/reset-meson.c b/drivers/reset/reset-meson.c
index 26dc54778615..13878ca2779d 100644
--- a/drivers/reset/reset-meson.c
+++ b/drivers/reset/reset-meson.c
@@ -116,14 +116,12 @@ MODULE_DEVICE_TABLE(of, meson_reset_dt_ids);
static int meson_reset_probe(struct platform_device *pdev)
{
struct meson_reset *data;
- struct resource *res;

data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
if (!data)
return -ENOMEM;

- res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- data->reg_base = devm_ioremap_resource(&pdev->dev, res);
+ data->reg_base = devm_platform_ioremap_resource(pdev, 0);
if (IS_ERR(data->reg_base))
return PTR_ERR(data->reg_base);

--
2.25.1

2023-02-18 15:39:36

by Martin Blumenstingl

Subject: Re: [PATCH v2] reset: meson: Use devm_platform_ioremap_resource()

On Thu, Feb 16, 2023 at 3:55 AM <[email protected]> wrote:
>
> From: Ye Xingchen <[email protected]>
>
> Convert platform_get_resource(), devm_ioremap_resource() to a single
> call to Use devm_platform_ioremap_resource(), as this is exactly
> what this function does.
>
> Suggested-by: Philipp Zabel <[email protected]>
> Signed-off-by: Ye Xingchen <[email protected]>
Thanks for your contribution! Please add my:
Reviewed-by: Martin Blumenstingl <[email protected]>