2023-02-17 03:14:54

by Thomas Weißschuh

Subject: [PATCH] livepatch: Make kobj_type structures constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definitions to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
kernel/livepatch/core.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/livepatch/core.c b/kernel/livepatch/core.c
index 201f0c0482fb..3da548755d8a 100644
--- a/kernel/livepatch/core.c
+++ b/kernel/livepatch/core.c
@@ -581,7 +581,7 @@ static void klp_kobj_release_patch(struct kobject *kobj)
complete(&patch->finish);
}

-static struct kobj_type klp_ktype_patch = {
+static const struct kobj_type klp_ktype_patch = {
.release = klp_kobj_release_patch,
.sysfs_ops = &kobj_sysfs_ops,
.default_groups = klp_patch_groups,
@@ -597,7 +597,7 @@ static void klp_kobj_release_object(struct kobject *kobj)
klp_free_object_dynamic(obj);
}

-static struct kobj_type klp_ktype_object = {
+static const struct kobj_type klp_ktype_object = {
.release = klp_kobj_release_object,
.sysfs_ops = &kobj_sysfs_ops,
.default_groups = klp_object_groups,
@@ -613,7 +613,7 @@ static void klp_kobj_release_func(struct kobject *kobj)
klp_free_func_nop(func);
}

-static struct kobj_type klp_ktype_func = {
+static const struct kobj_type klp_ktype_func = {
.release = klp_kobj_release_func,
.sysfs_ops = &kobj_sysfs_ops,
};

---
base-commit: 3ac88fa4605ec98e545fb3ad0154f575fda2de5f
change-id: 20230217-kobj_type-livepatch-74ddff6d453f

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-21 15:55:50

by Petr Mladek

Subject: Re: [PATCH] livepatch: Make kobj_type structures constant

On Fri 2023-02-17 03:14:41, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>

Reviewed-by: Petr Mladek <[email protected]>

Best Regards,
Petr

PS: I am going to queue this patch for 6.4. I could eventually add
it into a pull request for 6.3-rc if it was needed because of
a more important fix.

This patch is trivial. But even trivial patches should spend
at least few days in linux-next...

2023-03-09 10:52:33

by Petr Mladek

Subject: Re: [PATCH] livepatch: Make kobj_type structures constant

On Fri 2023-02-17 03:14:41, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definitions to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>

JFYI, the patch has been comitted into livepatching.git,
branch for-6.4/core.

Best Regards,
Petr