2023-02-17 09:44:30

by Florian Eckert

[permalink] [raw]
Subject: [PATCH v2 0/2] leds: ledtrig-tty: add tty_led_mode xtension

Hello,

here commes v2 of this series to add additional tty_led_modes.
Changes compared to the initial patchset with
[email protected] are.

Addressed review comments by Jiri Slaby are:

tty.h:
- Fix compilation error because of wrong rebaseing
- Remove empty lines
- Use new 'tty_get_mget' in 'tty_tiocmget'

ledtrg-tty.c:
- Update commit description
- Use enum for tty_led_mod in struct ledtrig_tty_date
- Rename sysfs file from 'mode' to 'tty_led_mode'
- Change tty_led_mode show function to use loop instead of switch/case
- Change tty_led_mode store function to use loop instead of switch/case
- Check return value of function tty_get_mget

Florian Eckert (2):
tty: new helper function tty_get_mget
trigger: ledtrig-tty: add additional modes

.../ABI/testing/sysfs-class-led-trigger-tty | 16 ++
drivers/leds/trigger/ledtrig-tty.c | 146 ++++++++++++++++--
drivers/tty/tty_io.c | 30 +++-
include/linux/tty.h | 1 +
4 files changed, 171 insertions(+), 22 deletions(-)

--
2.30.2