2023-02-15 17:32:24

by H. Nikolaus Schaller

Subject: [RFC 1/3] MIPS: DTS: jz4780: add #clock-cells to rtc_dev

This makes the driver present the clk32k signal if requested.
It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
module of the CI20 board.

Signed-off-by: H. Nikolaus Schaller <[email protected]>
---
arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
1 file changed, 2 insertions(+)

diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi b/arch/mips/boot/dts/ingenic/jz4780.dtsi
index c182a656d63bc..18affff85ce38 100644
--- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
+++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
@@ -155,6 +155,8 @@ rtc_dev: rtc@10003000 {

clocks = <&cgu JZ4780_CLK_RTCLK>;
clock-names = "rtc";
+
+ #clock-cells = <0>;
};

pinctrl: pin-controller@10010000 {
--
2.38.1

2023-02-17 16:31:30

by Paul Cercueil

Subject: Re: [RFC 1/3] MIPS: DTS: jz4780: add #clock-cells to rtc_dev

Le mercredi 15 février 2023 à 18:31 +0100, H. Nikolaus Schaller a
écrit :
> This makes the driver present the clk32k signal if requested.
> It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
> module of the CI20 board.
>
> Signed-off-by: H. Nikolaus Schaller <[email protected]>

Reviewed-by: Paul Cercueil <[email protected]>

Cheers,
-Paul

> ---
>  arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> index c182a656d63bc..18affff85ce38 100644
> --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> @@ -155,6 +155,8 @@ rtc_dev: rtc@10003000 {
>  
>                 clocks = <&cgu JZ4780_CLK_RTCLK>;
>                 clock-names = "rtc";
> +
> +               #clock-cells = <0>;
>         };
>  
>         pinctrl: pin-controller@10010000 {

2023-02-19 09:03:16

by Thomas Bogendoerfer

Subject: Re: [RFC 1/3] MIPS: DTS: jz4780: add #clock-cells to rtc_dev

On Fri, Feb 17, 2023 at 04:29:54PM +0000, Paul Cercueil wrote:
> Le mercredi 15 f?vrier 2023 ? 18:31 +0100, H. Nikolaus Schaller a
> ?crit?:
> > This makes the driver present the clk32k signal if requested.
> > It is needed to clock the PMU of the BCM4330 WiFi and Bluetooth
> > module of the CI20 board.
> >
> > Signed-off-by: H. Nikolaus Schaller <[email protected]>
>
> Reviewed-by: Paul Cercueil <[email protected]>
>
> Cheers,
> -Paul
>
> > ---
> > ?arch/mips/boot/dts/ingenic/jz4780.dtsi | 2 ++
> > ?1 file changed, 2 insertions(+)
> >
> > diff --git a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > index c182a656d63bc..18affff85ce38 100644
> > --- a/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > +++ b/arch/mips/boot/dts/ingenic/jz4780.dtsi
> > @@ -155,6 +155,8 @@ rtc_dev: rtc@10003000 {
> > ?
> > ????????????????clocks = <&cgu JZ4780_CLK_RTCLK>;
> > ????????????????clock-names = "rtc";
> > +
> > +???????????????#clock-cells = <0>;
> > ????????};
> > ?
> > ????????pinctrl: pin-controller@10010000 {

applied to mips-next.

Thomas.

--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]