2023-02-20 11:30:49

by Keguang Zhang

Subject: [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards

Add two Loongson-1 based boards: LSGZ 1B and Smartloongson 1C.

Signed-off-by: Keguang Zhang <[email protected]>
---
.../devicetree/bindings/mips/loongson/devices.yaml | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
index f13ce386f42c..6ed6e8d1c0a6 100644
--- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
+++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
@@ -37,6 +37,16 @@ properties:
items:
- const: loongson,loongson64v-4core-virtio

+ - description: LSGZ 1B Development Board
+ items:
+ - const: lsgz,1b
+ - const: loongson,ls1b
+
+ - description: Smart Loongson 1C Board
+ items:
+ - const: smartloongson,1c
+ - const: loongson,ls1c
+
additionalProperties: true

...

base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8
--
2.34.1

2023-02-20 12:36:58

by Krzysztof Kozlowski

Subject: Re: [PATCH] dt-bindings: mips: loongson: Add Loongson-1 based boards

On 20/02/2023 12:30, Keguang Zhang wrote:
> Add two Loongson-1 based boards: LSGZ 1B and Smartloongson 1C.
>
> Signed-off-by: Keguang Zhang <[email protected]>
> ---
> .../devicetree/bindings/mips/loongson/devices.yaml | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/mips/loongson/devices.yaml b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> index f13ce386f42c..6ed6e8d1c0a6 100644
> --- a/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> +++ b/Documentation/devicetree/bindings/mips/loongson/devices.yaml
> @@ -37,6 +37,16 @@ properties:
> items:
> - const: loongson,loongson64v-4core-virtio
>
> + - description: LSGZ 1B Development Board
> + items:
> + - const: lsgz,1b

1. Undocumented vendor prefix
2. This should be rather enum as it will grow with more boards. Also
description could be rather - LS1B based boards.

> + - const: loongson,ls1b
> +
> + - description: Smart Loongson 1C Board
> + items:
> + - const: smartloongson,1c

Same comments.

> + - const: loongson,ls1c
> +
> additionalProperties: true
>
> ...
>
> base-commit: 39459ce717b863556d7d75466fcbd904a6fbbbd8

Best regards,
Krzysztof