2023-02-20 12:21:39

by Rohit Chavan

Subject: [PATCH] RDMA/mlx5: Coding style fix

Signed-off-by: Rohit Chavan <[email protected]>
---
drivers/infiniband/hw/mlx5/qp.c | 9 ++++-----
1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/qp.c b/drivers/infiniband/hw/mlx5/qp.c
index cf953d23d18d..45c45e57bbb8 100644
--- a/drivers/infiniband/hw/mlx5/qp.c
+++ b/drivers/infiniband/hw/mlx5/qp.c
@@ -2769,9 +2769,9 @@ static void process_vendor_flag(struct mlx5_ib_dev *dev, int *flags, int flag,
case MLX5_QP_FLAG_SCATTER_CQE:
case MLX5_QP_FLAG_ALLOW_SCATTER_CQE:
/*
- * We don't return error if these flags were provided,
- * and mlx5 doesn't have right capability.
- */
+ * We don't return error if these flags were provided,
+ * and mlx5 doesn't have right capability.
+ */
*flags &= ~(MLX5_QP_FLAG_SCATTER_CQE |
MLX5_QP_FLAG_ALLOW_SCATTER_CQE);
return;
@@ -5514,8 +5514,7 @@ int mlx5_ib_modify_wq(struct ib_wq *wq, struct ib_wq_attr *wq_attr,
if (wq_attr->flags_mask & IB_WQ_FLAGS_CVLAN_STRIPPING) {
if (!(MLX5_CAP_GEN(dev->mdev, eth_net_offloads) &&
MLX5_CAP_ETH(dev->mdev, vlan_cap))) {
- mlx5_ib_dbg(dev, "VLAN offloads are not "
- "supported\n");
+ mlx5_ib_dbg(dev, "VLAN offloads are not supported\n");
err = -EOPNOTSUPP;
goto out;
}
--
2.30.2

2023-02-22 08:04:05

by Leon Romanovsky

Subject: Re: [PATCH] RDMA/mlx5: Coding style fix

On Mon, Feb 20, 2023 at 05:51:16PM +0530, Rohit Chavan wrote:
> Signed-off-by: Rohit Chavan <[email protected]>
> ---
> drivers/infiniband/hw/mlx5/qp.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)


Please try to avoid empty commit messages.

And we are in merge window now, so new version of this patch will need
to wait till -rc1.

Thanks