2023-02-18 04:36:58

by void0red

Subject: [PATCH] btrfs: handle btrfs_del_item errors in __btrfs_update_delayed_inode

Even if the slot is already read out, we may still need to re-balance
the tree, thus it can cause error in that btrfs_del_item() call.

Link: https://lore.kernel.org/linux-btrfs/[email protected]/T/#t

Signed-off-by: void0red <[email protected]>
---
fs/btrfs/delayed-inode.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
index cac5169eaf8d..88a5d893972d 100644
--- a/fs/btrfs/delayed-inode.c
+++ b/fs/btrfs/delayed-inode.c
@@ -1043,7 +1043,7 @@ static int __btrfs_update_delayed_inode(struct btrfs_trans_handle *trans,
* so there is only one iref. The case that several irefs are
* in the same item doesn't exist.
*/
- btrfs_del_item(trans, root, path);
+ ret = btrfs_del_item(trans, root, path);
out:
btrfs_release_delayed_iref(node);
btrfs_release_path(path);
--
2.34.1

2023-02-18 04:41:26

by Qu Wenruo

Subject: Re: [PATCH] btrfs: handle btrfs_del_item errors in __btrfs_update_delayed_inode

On 2023/2/18 12:36, void0red wrote:
> Even if the slot is already read out, we may still need to re-balance
> the tree, thus it can cause error in that btrfs_del_item() call.
>
> Link: https://lore.kernel.org/linux-btrfs/[email protected]/T/#t
>
> Signed-off-by: void0red <[email protected]>

Reviewed-by: Qu Wenruo <[email protected]>

Thanks,
Qu

> ---
> fs/btrfs/delayed-inode.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/btrfs/delayed-inode.c b/fs/btrfs/delayed-inode.c
> index cac5169eaf8d..88a5d893972d 100644
> --- a/fs/btrfs/delayed-inode.c
> +++ b/fs/btrfs/delayed-inode.c
> @@ -1043,7 +1043,7 @@ static int __btrfs_update_delayed_inode(struct btrfs_trans_handle *trans,
> * so there is only one iref. The case that several irefs are
> * in the same item doesn't exist.
> */
> - btrfs_del_item(trans, root, path);
> + ret = btrfs_del_item(trans, root, path);
> out:
> btrfs_release_delayed_iref(node);
> btrfs_release_path(path);

2023-02-20 20:08:18

by David Sterba

Subject: Re: [PATCH] btrfs: handle btrfs_del_item errors in __btrfs_update_delayed_inode

On Sat, Feb 18, 2023 at 12:36:48PM +0800, void0red wrote:
> Even if the slot is already read out, we may still need to re-balance
> the tree, thus it can cause error in that btrfs_del_item() call.
>
> Link: https://lore.kernel.org/linux-btrfs/[email protected]/T/#t
>
> Signed-off-by: void0red <[email protected]>

Added to misc-next, thanks.