2023-02-21 23:14:35

by Leo Li

Subject: [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032

Since the AR8032 part does not support wol, remove related callbacks
from it.

Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")
Signed-off-by: Li Yang <[email protected]>
---
drivers/net/phy/at803x.c | 2 --
1 file changed, 2 deletions(-)

diff --git a/drivers/net/phy/at803x.c b/drivers/net/phy/at803x.c
index 2102279b3964..ac47a1d681b2 100644
--- a/drivers/net/phy/at803x.c
+++ b/drivers/net/phy/at803x.c
@@ -2079,8 +2079,6 @@ static struct phy_driver at803x_driver[] = {
.flags = PHY_POLL_CABLE_TEST,
.config_init = at803x_config_init,
.link_change_notify = at803x_link_change_notify,
- .set_wol = at803x_set_wol,
- .get_wol = at803x_get_wol,
.suspend = at803x_suspend,
.resume = at803x_resume,
/* PHY_BASIC_FEATURES */
--
2.38.0

2023-02-24 03:06:01

by Jakub Kicinski

Subject: Re: [PATCH v2 2/2] net: phy: at803x: remove set/get wol callbacks for AR8032

On Tue, 21 Feb 2023 17:14:11 -0600 Li Yang wrote:
> Since the AR8032 part does not support wol, remove related callbacks
> from it.
>
> Fixes: 5800091a2061 ("net: phy: at803x: add support for AR8032 PHY")

Is there a reason you didn't CC David Bauer <[email protected]>,
the author of the change under Fixes? If no please repost and add him.