Subject: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

From: Sasha Finkelstein <[email protected]>

This patch fixes an incorrect loop exit condition in code that replaces
'/' symbols in the board name. There might also be a memory corruption
issue here, but it is unlikely to be a real problem.

Cc: <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
---
drivers/bluetooth/btbcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 3006e2a0f37e..43e98a598bd9 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev)
len = strlen(tmp) + 1;
board_type = devm_kzalloc(dev, len, GFP_KERNEL);
strscpy(board_type, tmp, len);
- for (i = 0; i < board_type[i]; i++) {
+ for (i = 0; i < len; i++) {
if (board_type[i] == '/')
board_type[i] = '-';
}

---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230224-btbcm-wtf-ff32fed3e930

Best regards,
--
Sasha Finkelstein <[email protected]>



2023-03-14 23:10:34

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 10 Mar 2023 11:28:42 +0100 you wrote:
> From: Sasha Finkelstein <[email protected]>
>
> This patch fixes an incorrect loop exit condition in code that replaces
> '/' symbols in the board name. There might also be a memory corruption
> issue here, but it is unlikely to be a real problem.
>
> Cc: <[email protected]>
> Signed-off-by: Sasha Finkelstein <[email protected]>
>
> [...]

Here is the summary with links:
- [RESEND] bluetooth: btbcm: Fix logic error in forming the board name.
https://git.kernel.org/bluetooth/bluetooth-next/c/3629e1ce7721

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html