Subject: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

From: Sasha Finkelstein <[email protected]>

This patch fixes an incorrect loop exit condition in code that replaces
'/' symbols in the board name. There might also be a memory corruption
issue here, but it is unlikely to be a real problem.

Signed-off-by: Sasha Finkelstein <[email protected]>
---
drivers/bluetooth/btbcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 3006e2a0f37e..43e98a598bd9 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev)
len = strlen(tmp) + 1;
board_type = devm_kzalloc(dev, len, GFP_KERNEL);
strscpy(board_type, tmp, len);
- for (i = 0; i < board_type[i]; i++) {
+ for (i = 0; i < len; i++) {
if (board_type[i] == '/')
board_type[i] = '-';
}

---
base-commit: c9c3395d5e3dcc6daee66c6908354d47bf98cb0c
change-id: 20230224-btbcm-wtf-ff32fed3e930

Best regards,
--
Sasha Finkelstein <[email protected]>



2023-03-10 08:12:16

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

On Fri, Mar 10, 2023 at 09:07:33AM +0100, Sasha Finkelstein via B4 Relay wrote:
> From: Sasha Finkelstein <[email protected]>
>
> This patch fixes an incorrect loop exit condition in code that replaces
> '/' symbols in the board name. There might also be a memory corruption
> issue here, but it is unlikely to be a real problem.
>
> Signed-off-by: Sasha Finkelstein <[email protected]>
> ---
> drivers/bluetooth/btbcm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

<formletter>

This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.

</formletter>

2023-03-10 09:42:37

by Sasha Finkelstein

[permalink] [raw]
Subject: Re: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read:
> https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> for how to do this properly.
>
> </formletter>
Sorry about that, let's just skip the stable tree part for now then.

2023-03-10 09:53:31

by Greg KH

[permalink] [raw]
Subject: Re: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

On Fri, Mar 10, 2023 at 10:41:28AM +0100, Sasha Finkelstein wrote:
> > <formletter>
> >
> > This is not the correct way to submit patches for inclusion in the
> > stable kernel tree. Please read:
> > https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
> > for how to do this properly.
> >
> > </formletter>
> Sorry about that, let's just skip the stable tree part for now then.

That's not how to solve the problem, if it's a bug that needs to be
fixed in stable kernels, submit it properly and it will automatically be
propagated there as the documentation states.

thanks,

greg k-h