2023-02-24 20:30:03

by Nick Alcock

Subject: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in non-modules

Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.

So remove it in the files in this commit, none of which can be built as
modules.

Signed-off-by: Nick Alcock <[email protected]>
Suggested-by: Luis Chamberlain <[email protected]>
Cc: Luis Chamberlain <[email protected]>
Cc: [email protected]
Cc: [email protected]
Cc: Hitomi Hasegawa <[email protected]>
Cc: Srinivas Kandagatla <[email protected]>
Cc: Michal Simek <[email protected]>
Cc: [email protected]
---
drivers/nvmem/zynqmp_nvmem.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
index e28d7b133e11..844c1d861dea 100644
--- a/drivers/nvmem/zynqmp_nvmem.c
+++ b/drivers/nvmem/zynqmp_nvmem.c
@@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver);

MODULE_AUTHOR("Michal Simek <[email protected]>, Nava kishore Manne <[email protected]>");
MODULE_DESCRIPTION("ZynqMP NVMEM driver");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303

2023-02-27 11:51:27

by Michal Simek

Subject: Re: [PATCH 24/27] firmware: xilinx: remove MODULE_LICENSE in non-modules

On 2/24/23 16:08, Nick Alcock wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <[email protected]>
> Suggested-by: Luis Chamberlain <[email protected]>
> Cc: Luis Chamberlain <[email protected]>
> Cc: [email protected]
> Cc: [email protected]
> Cc: Hitomi Hasegawa <[email protected]>
> Cc: Srinivas Kandagatla <[email protected]>
> Cc: Michal Simek <[email protected]>
> Cc: [email protected]
> ---
> drivers/nvmem/zynqmp_nvmem.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/nvmem/zynqmp_nvmem.c b/drivers/nvmem/zynqmp_nvmem.c
> index e28d7b133e11..844c1d861dea 100644
> --- a/drivers/nvmem/zynqmp_nvmem.c
> +++ b/drivers/nvmem/zynqmp_nvmem.c
> @@ -78,4 +78,3 @@ module_platform_driver(zynqmp_nvmem_driver);
>
> MODULE_AUTHOR("Michal Simek <[email protected]>, Nava kishore Manne <[email protected]>");
> MODULE_DESCRIPTION("ZynqMP NVMEM driver");
> -MODULE_LICENSE("GPL");
> --
> 2.39.1.268.g9de2f9a303
>

I would prefer to fix this by changing Kconfig symbol from bool to tristate.

Thanks,
Michal