2023-02-26 06:37:27

by Lizhe

[permalink] [raw]
Subject: [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave

variable slave in spi_alloc_master() or spi_alloc_slave()
has been assigned. it is not necessary to be assigned again

Signed-off-by: Lizhe <[email protected]>
---
drivers/spi/spi-rockchip.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/spi/spi-rockchip.c b/drivers/spi/spi-rockchip.c
index 79242dc5272d..a45717eb8890 100644
--- a/drivers/spi/spi-rockchip.c
+++ b/drivers/spi/spi-rockchip.c
@@ -772,7 +772,6 @@ static int rockchip_spi_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, ctlr);

rs = spi_controller_get_devdata(ctlr);
- ctlr->slave = slave_mode;

/* Get basic io resource and map it */
mem = platform_get_resource(pdev, IORESOURCE_MEM, 0);
--
2.34.1



2023-03-06 13:05:30

by Mark Brown

[permalink] [raw]
Subject: Re: [PATCH v1] drivers/spi-rockchip.c : Remove redundant variable slave

On Sun, 26 Feb 2023 14:33:34 +0800, Lizhe wrote:
> variable slave in spi_alloc_master() or spi_alloc_slave()
> has been assigned. it is not necessary to be assigned again
>
>

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next

Thanks!

[1/1] drivers/spi-rockchip.c : Remove redundant variable slave
commit: 8c220e6c6da9c2f70a78ba8b3121893b3634a54c

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark